Merge lp:~james-w/linaro-image-tools/fix-device-quoting into lp:linaro-image-tools/11.11

Proposed by James Westby
Status: Merged
Merge reported by: James Westby
Merged at revision: not available
Proposed branch: lp:~james-w/linaro-image-tools/fix-device-quoting
Merge into: lp:linaro-image-tools/11.11
Diff against target: 33 lines (+6/-2)
2 files modified
debian/changelog (+4/-0)
linaro-media-create (+2/-2)
To merge this branch: bzr merge lp:~james-w/linaro-image-tools/fix-device-quoting
Reviewer Review Type Date Requested Status
Loïc Minier (community) Disapprove
Review via email: mp+34810@code.launchpad.net

Description of the change

Hi,

Here's a patch from Matt Domsch by email to fix an instance of improper
quoting that prevent him from using the tool.

Thanks,

James

To post a comment you must log in.
58. By James Westby

Merge trunk.

Revision history for this message
Loïc Minier (lool) wrote :

Hey

Sorry, I have already committed that patch in trunk

Thanks,

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-09-07 08:56:14 +0000
3+++ debian/changelog 2010-09-07 21:52:42 +0000
4@@ -13,6 +13,10 @@
5 uuidgen-runtime and do not depend on util-linux, e2fsprogs and coreutils
6 as these are Essential: yes; thanks Colin Watson.
7
8+ [ Matt Domsch ]
9+ * Fix an instance of underquoting which caused problems on systems
10+ with odd filenames in /dev/disk/by-id/.
11+
12 -- Loïc Minier <loic.minier@linaro.org> Sun, 05 Sep 2010 10:26:20 +0200
13
14 linaro-image-tools (0.1) maverick; urgency=low
15
16=== modified file 'linaro-media-create'
17--- linaro-media-create 2010-09-07 21:38:12 +0000
18+++ linaro-media-create 2010-09-07 21:52:42 +0000
19@@ -56,12 +56,12 @@
20 get_mmcs_by_id() {
21 if [ ! ${IMAGE_FILE} ]; then
22 for device in /dev/disk/by-id/*; do
23- if [ `realpath $device` = $MMC ]; then
24+ if [ `realpath "$device"` = $MMC ]; then
25 if echo "$device" | grep -q -- "-part[0-9]*$"; then
26 echo "device $MMC must not be a partition part ($device)" 1>&2
27 exit 1
28 fi
29- for part_id in `ls "$device-part"*`; do
30+ for part_id in `ls "$device"-part*`; do
31 part=`realpath $part_id`
32 part_no=`echo $part_id | sed -e 's/.*-part//g'`
33 # echo "part $part_no found: $part_id" 1>&2

Subscribers

People subscribed via source and target branches