Merge lp:~james-w/linaro-image-tools/architecture-in-filename into lp:linaro-image-tools/11.11

Proposed by James Westby
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: 111
Merged at revision: 68
Proposed branch: lp:~james-w/linaro-image-tools/architecture-in-filename
Merge into: lp:linaro-image-tools/11.11
Prerequisite: lp:~james-w/linaro-image-tools/metadata-from-config
Diff against target: 35 lines (+5/-4)
2 files modified
hwpack/hardwarepack.py (+3/-2)
hwpack/tests/test_hardwarepack.py (+2/-2)
To merge this branch: bzr merge lp:~james-w/linaro-image-tools/architecture-in-filename
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle (community) Approve
Review via email: mp+35127@code.launchpad.net

Description of the change

Hi,

A small branch to put the architecture name in the hwpack filename, to tell
them apart and stop them colliding when you build multiple architectures.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Very exciting.

 merge approved

Cheers,
mwh

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hwpack/hardwarepack.py'
2--- hwpack/hardwarepack.py 2010-09-10 15:54:08 +0000
3+++ hwpack/hardwarepack.py 2010-09-10 16:01:43 +0000
4@@ -116,8 +116,9 @@
5 support_suffix = ""
6 else:
7 support_suffix = "_%s" % self.metadata.support
8- return "hwpack_%s_%s%s.tar.gz" % (
9- self.metadata.name, self.metadata.version, support_suffix)
10+ return "hwpack_%s_%s_%s%s.tar.gz" % (
11+ self.metadata.name, self.metadata.version,
12+ self.metadata.architecture, support_suffix)
13
14 def add_apt_sources(self, sources):
15 """Add APT sources to the hardware pack.
16
17=== modified file 'hwpack/tests/test_hardwarepack.py'
18--- hwpack/tests/test_hardwarepack.py 2010-09-10 15:54:08 +0000
19+++ hwpack/tests/test_hardwarepack.py 2010-09-10 16:01:43 +0000
20@@ -145,13 +145,13 @@
21
22 def test_filename(self):
23 hwpack = HardwarePack(self.metadata)
24- self.assertEqual("hwpack_ahwpack_4.tar.gz", hwpack.filename())
25+ self.assertEqual("hwpack_ahwpack_4_armel.tar.gz", hwpack.filename())
26
27 def test_filename_with_support(self):
28 metadata = Metadata("ahwpack", "4", "armel", support="supported")
29 hwpack = HardwarePack(metadata)
30 self.assertEqual(
31- "hwpack_ahwpack_4_supported.tar.gz", hwpack.filename())
32+ "hwpack_ahwpack_4_armel_supported.tar.gz", hwpack.filename())
33
34 def get_tarfile(self, hwpack):
35 fileobj = StringIO()

Subscribers

People subscribed via source and target branches