launchpadlib

Merge lp:~james-w/launchpadlib/fix-default-version-in-test into lp:launchpadlib

  1. fix-default-version-in-test
  2. Merge into trunk
Proposed by James Westby on 2010-07-15
Status: Merged
Merged at revision: 92
Proposed branch: lp:~james-w/launchpadlib/fix-default-version-in-test
Merge into: lp:launchpadlib
Diff against target: 12 lines (+1/-1)
1 file modified
src/launchpadlib/tests/test_launchpad.py (+1/-1)
To merge this branch: bzr merge lp:~james-w/launchpadlib/fix-default-version-in-test
Reviewer Review Type Date Requested Status
Leonard Richardson (community) 2010-07-15 Approve on 2010-07-19
Review via email: mp+29943@code.launchpad.net

Description of the Change

Hi,

Here's a small change to fix bug 488448.

NoNetworkLaunchpad inherits from Launchpad, for which
login_with has a default of DEFAULT_VERSION.

That's what ends up getting passed to
NoNetworkLaunchpad.get_token_and_login, and so what
we should test.

Thanks,

James

To post a comment you must log in.
Leonard Richardson (leonardr) wrote :

Approved and merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/launchpadlib/tests/test_launchpad.py'
2--- src/launchpadlib/tests/test_launchpad.py 2010-03-04 19:26:40 +0000
3+++ src/launchpadlib/tests/test_launchpad.py 2010-07-15 00:54:40 +0000
4@@ -228,7 +228,7 @@
5 timeout=timeout,
6 proxy_info=proxy_info,
7 cache=os.path.join(self.temp_dir, 'api.example.com', 'cache'),
8- version='beta')
9+ version=NoNetworkLaunchpad.DEFAULT_VERSION)
10 self.assertEqual(launchpad.passed_in_kwargs, expected_arguments)
11
12 def test_anonymous_login(self):

Subscribers

People subscribed via source and target branches