Launchpad itself

Merge lp:~james-w/launchpad/kill-task_age into lp:launchpad

  1. kill-task_age
  2. Merge into devel
Proposed by James Westby on 2010-02-01
Status: Merged
Merged at revision: not available
Proposed branch: lp:~james-w/launchpad/kill-task_age
Merge into: lp:launchpad
Diff against target: 37 lines (+2/-11)
2 files modified
lib/lp/bugs/interfaces/bugtask.py (+2/-4)
lib/lp/bugs/stories/webservice/xx-bug.txt (+0/-7)
To merge this branch: bzr merge lp:~james-w/launchpad/kill-task_age
Reviewer Review Type Date Requested Status
Francis J. Lacoste (community) release-critical 2010-02-02 Approve on 2010-02-02
Eleanor Berger (community) 2010-02-01 Approve on 2010-02-01
Review via email: mp+18418@code.launchpad.net
To post a comment you must log in.
James Westby (james-w) wrote :

Kill task_age to fix bug 515747.

Thanks,

James

Eleanor Berger (intellectronica) wrote :

Thanks for the branch, James.

review: Approve
Francis J. Lacoste (flacoste) :
review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/interfaces/bugtask.py'
2--- lib/lp/bugs/interfaces/bugtask.py 2010-01-23 21:42:36 +0000
3+++ lib/lp/bugs/interfaces/bugtask.py 2010-02-01 22:52:17 +0000
4@@ -470,11 +470,9 @@
5 description=_("The age of this task, expressed as the "
6 "length of time between the creation date "
7 "and now."))
8- task_age = exported(
9- Int(title=_("Age of the bug task"),
10+ task_age = Int(title=_("Age of the bug task"),
11 description=_("The age of this task in seconds, a delta between "
12- "now and the date the bug task was created."),
13- readonly=True))
14+ "now and the date the bug task was created."))
15 owner = exported(
16 Reference(title=_("The owner"), schema=IPerson, readonly=True))
17 target = exported(Reference(
18
19=== modified file 'lib/lp/bugs/stories/webservice/xx-bug.txt'
20--- lib/lp/bugs/stories/webservice/xx-bug.txt 2010-01-26 19:36:17 +0000
21+++ lib/lp/bugs/stories/webservice/xx-bug.txt 2010-02-01 22:52:17 +0000
22@@ -331,15 +331,8 @@
23 self_link: u'http://api.../debian/+source/mozilla-firefox/+bug/1'
24 status: u'Confirmed'
25 target_link: u'http://api.../debian/+source/mozilla-firefox'
26- task_age: ...
27 title: u'Bug #1 in mozilla-firefox (Debian): "Firefox does not support SVG"'
28
29-Because task age is a dynamic calculation between now and the date_created
30-we will just verify that an integer is returned.
31-
32- >>> print type(bug_one_bugtasks[0]['task_age'])
33- <type 'int'>
34-
35 The collection of bug tasks is not exposed as a resource:
36
37 >>> webservice.get("/bug_tasks").status