Merge lp:~james-w/canonical-identity-provider/fast-team-memberships into lp:canonical-identity-provider/release

[James Westby]

Rewrite the team participation query to run much faster.

This version ran the sample query in 3ms, vs. >11000ms for the old query.

Thanks to wgrant and nessita for figuring out how to make it fast.

Hi,

This should be a huge speedup to team participation queries, thanks to
wgrant and nessita.

Thanks,

James

[Ricardo Kirkner (ricardokirkner)]

LGTM

review: Approve

[Natalia Bidart (nataliabidart)]

Looks good!

review: Approve

=== modified file 'src/identityprovider/models/team.py'
--- src/identityprovider/models/team.py	2013-08-23 13:03:58 +0000
+++ src/identityprovider/models/team.py	2013-08-23 15:02:29 +0000
@@ -17,21 +17,15 @@
         # Someone that has no person associated with the account can't
         # be a member of any teams.
         return []
-    teams = Person.objects.filter(
-        name__in=team_names,      # All team names provided
-        teamowner__isnull=False,  # Only teams
+    teams = TeamParticipation.objects.filter(
+        person=user.person,
+        team__name__in=team_names,
     )
     if not include_private:
         teams = teams.filter(
-            visibility=PERSON_VISIBILITY_PUBLIC)
-    # Only teams in which the user is a member.
-    # Only actual membership counts: If the user owns a team but isn't a
-    # member, they aren't a member.
-    teams = teams.filter(
-        models.Q(team_participations__person=user.person)
-    )
+            team__visibility=PERSON_VISIBILITY_PUBLIC)
     # By default it's a query set result, not a true list
-    return list(teams.values_list('name', flat=True))
+    return list(teams.values_list('team__name', flat=True))
 
 
 class TeamParticipation(models.Model):