Canonical SSO provider

Merge lp:~james-w/canonical-identity-provider/doubled-email-acceptance into lp:canonical-identity-provider/release

  1. doubled-email-acceptance
  2. Merge into trunk
Proposed by James Westby
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: no longer in the source branch.
Merged at revision: 1043
Proposed branch: lp:~james-w/canonical-identity-provider/doubled-email-acceptance
Merge into: lp:canonical-identity-provider/release
Diff against target: 11 lines (+1/-1)
1 file modified
acceptance/tests/emails/valid_address.py (+1/-1)
To merge this branch: bzr merge lp:~james-w/canonical-identity-provider/doubled-email-acceptance
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+182962@code.launchpad.net

Commit message

Use a generated test email for valid_address acceptance test.

Using a fixed email means that it can clash with data already in the system.

Description of the change

Hi,

The valid_email test uses a fixed email address for tests. That can
mean that the test outcome depends on the state of the db. Switch
to using a generated address instead.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'acceptance/tests/emails/valid_address.py'
2--- acceptance/tests/emails/valid_address.py 2013-06-10 13:49:47 +0000
3+++ acceptance/tests/emails/valid_address.py 2013-08-29 17:16:43 +0000
4@@ -24,7 +24,7 @@
5 go_to(urls.EMAILS)
6 wait_for(assert_title_contains, "email addresses")
7
8-address = 'testme@foo.com'
9+address = mail.make_unique_test_email_address()
10 write_textfield('id_newemail', address)
11 click_button(get_element(name='continue'))
12