Merge lp:~james-page/ubuntu/quantal/icedtea-web/java7-transition into lp:ubuntu/quantal/icedtea-web

Proposed by James Page on 2012-07-09
Status: Merged
Merge reported by: James Page
Merged at revision: not available
Proposed branch: lp:~james-page/ubuntu/quantal/icedtea-web/java7-transition
Merge into: lp:ubuntu/quantal/icedtea-web
Diff against target: 207 lines (+59/-33)
5 files modified
debian/PLUGIN7.postinst.in (+29/-19)
debian/changelog (+16/-0)
debian/control (+5/-4)
debian/control.in (+5/-4)
debian/rules (+4/-6)
To merge this branch: bzr merge lp:~james-page/ubuntu/quantal/icedtea-web/java7-transition
Reviewer Review Type Date Requested Status
Clint Byrum Approve on 2012-07-20
Matthias Klose 2012-07-09 Pending
Ubuntu branches 2012-07-09 Pending
Review via email: mp+113959@code.launchpad.net

Description of the Change

Updates for transition to Java 7 as default including:

- Build with openjdk-7
- Prefer java 7 over java 6

To post a comment you must log in.
45. By James Page on 2012-07-11

Minor tweak to check for upgrade alternate/delete

Clint Byrum (clint-fewbar) wrote :

This looks good, but I will defer to doko for uploading.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/PLUGIN7.postinst.in'
2--- debian/PLUGIN7.postinst.in 2012-03-05 06:00:36 +0000
3+++ debian/PLUGIN7.postinst.in 2012-07-11 10:11:44 +0000
4@@ -13,31 +13,41 @@
5
6 case "$1" in
7 configure)
8- for browser_dir in $browser_dirs; do
9- if [ $browser_dir = xulrunner-addons ]; then
10- browser=xulrunner-1.9
11- else
12- browser=$browser_dir
13- fi
14+ for browser_dir in $browser_dirs; do
15+ if [ $browser_dir = xulrunner-addons ]; then
16+ browser=xulrunner-1.9
17+ else
18+ browser=$browser_dir
19+ fi
20
21- if [ -n "$multiarch" ] && [ "$DPKG_MAINTSCRIPT_ARCH" != $(dpkg --print-architecture) ]; then
22- priority=$(expr $priority - 1)
23- fi
24+ if [ -n "$multiarch" ] && [ "$DPKG_MAINTSCRIPT_ARCH" != $(dpkg --print-architecture) ]; then
25+ priority=$(expr $priority - 1)
26+ fi
27
28 if [ -n "$multiarch" ] && [ -n "$2" ]; then
29 if [ -n "$(update-alternatives --list $browser-javaplugin.so 2>/dev/null | grep ^$old_basedir/)" ]; then
30- update-alternatives --remove $browser-javaplugin.so $OLD_PLUGINPTH || true
31- fi
32- fi
33+ update-alternatives --remove $browser-javaplugin.so $OLD_PLUGINPTH || true
34+ fi
35+ fi
36+
37+ if [ -n "$2" ]; then
38+ # Check to see if alternates priority needs to be upgraded
39+ install_priority=$(update-alternatives --query $browser-javaplugin.so | \
40+ grep "Alternative: $PLUGINPTH" -A1 | sed -rne 's,^Priority: (.*),\1,p')
41+ if [ -n "$install_priority" ] && [ "$priority" != "$install_priority" ]; then
42+ # Remove current alternate - it will get re-installed later
43+ update-alternatives --remove $browser-javaplugin.so $PLUGINPTH || true
44+ fi
45+ fi
46
47 if [ -z "$(update-alternatives --list $browser-javaplugin.so 2>/dev/null | grep ^$basedir/)" ]; then
48- update-alternatives --quiet --install \
49- /usr/lib/$browser_dir/plugins/libjavaplugin.so \
50- $browser-javaplugin.so \
51- $PLUGINPTH \
52- $priority
53- fi
54- done
55+ update-alternatives --quiet --install \
56+ /usr/lib/$browser_dir/plugins/libjavaplugin.so \
57+ $browser-javaplugin.so \
58+ $PLUGINPTH \
59+ $priority
60+ fi
61+ done
62 esac
63
64 #DEBHELPER#
65
66=== modified file 'debian/changelog'
67--- debian/changelog 2012-04-09 16:44:35 +0000
68+++ debian/changelog 2012-07-11 10:11:44 +0000
69@@ -1,3 +1,19 @@
70+icedtea-web (1.2-2ubuntu2) quantal; urgency=low
71+
72+ * Transition to openjdk-7 as default-java:
73+ - d/control: icedtea-plugin Depends: icedtea-6-plugin -> icedtea-7-plugin.
74+ - d/control: Build-Depend openjdk-6-jdk -> openjdk-7-jdk.
75+ - d/control: icedtea-netx: Make openjdk-7-jre the primary dependency.
76+ - d/rules: Use openjdk-7 to configure/build icedtea-web, pickup openjdk-7
77+ png files.
78+ - d/PLUGIN7.postinst.in: Added code to remove existing alternate if
79+ priority has changed in anyway from that of the installed version.
80+ This triggers a re-install later in the script with the updated
81+ priority.
82+ - d/rules: Prioritize java7 version above java6.
83+
84+ -- James Page <james.page@ubuntu.com> Mon, 09 Jul 2012 12:46:15 +0100
85+
86 icedtea-web (1.2-2ubuntu1) precise; urgency=low
87
88 * Regenerate the control file.
89
90=== modified file 'debian/control'
91--- debian/control 2012-04-09 16:44:35 +0000
92+++ debian/control 2012-07-11 10:11:44 +0000
93@@ -1,9 +1,10 @@
94 Source: icedtea-web
95 Section: java
96 Priority: extra
97-Maintainer: OpenJDK Team <openjdk@lists.launchpad.net>
98+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
99+XSBC-Original-Maintainer: OpenJDK Team <openjdk@lists.launchpad.net>
100 Uploaders: Matthias Klose <doko@ubuntu.com>, Damien Raude-Morvan <drazzib@debian.org>
101-Build-Depends: debhelper (>= 5), firefox-dev, openjdk-6-jdk (>= 6b23~pre10~), zip, lsb-release, libgtk2.0-dev, pkg-config, default-jre-headless
102+Build-Depends: debhelper (>= 5), firefox-dev, openjdk-7-jdk, zip, lsb-release, libgtk2.0-dev, pkg-config, default-jre-headless
103 Standards-Version: 3.9.3
104 Homepage: http://icedtea.classpath.org/wiki/IcedTea-Web
105 Vcs-Bzr: http://bazaar.launchpad.net/~openjdk/openjdk/icedtea-web
106@@ -12,7 +13,7 @@
107 Package: icedtea-netx
108 Architecture: any
109 Multi-Arch: same
110-Depends: ${netx:Depends}, openjdk-6-jre (>= 6b23~pre10~) | openjdk-7-jre, ${shlibs:Depends}, ${misc:Depends}
111+Depends: ${netx:Depends}, openjdk-7-jre | openjdk-6-jre (>= 6b23~pre10~), ${shlibs:Depends}, ${misc:Depends}
112 Conflicts: openjdk-6-jre (<< 6b18-1.8.7-3), openjdk-6-jre-headless (<< 6b18-1.8.7-3)
113 Replaces: openjdk-6-jre (<< 6b18-1.8.7-3), openjdk-6-jre-headless (<< 6b18-1.8.7-3)
114 Description: NetX - implementation of the Java Network Launching Protocol (JNLP)
115@@ -38,7 +39,7 @@
116 Package: icedtea-plugin
117 Section: web
118 Architecture: all
119-Depends: icedtea-6-plugin, ${misc:Depends}
120+Depends: icedtea-7-plugin, ${misc:Depends}
121 Description: web browser plugin to execute Java applets (dependency package)
122 IcedTeaPlugin is a web browser plugin to execute Java applets, supporting
123 LiveConnect/JavaScript. It is targeted for xulrunner-1.9 and compatible
124
125=== modified file 'debian/control.in'
126--- debian/control.in 2012-03-03 12:30:45 +0000
127+++ debian/control.in 2012-07-11 10:11:44 +0000
128@@ -1,9 +1,10 @@
129 Source: icedtea-web
130 Section: java
131 Priority: extra
132-Maintainer: OpenJDK Team <openjdk@lists.launchpad.net>
133+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
134+XSBC-Original-Maintainer: OpenJDK Team <openjdk@lists.launchpad.net>
135 Uploaders: Matthias Klose <doko@ubuntu.com>, Damien Raude-Morvan <drazzib@debian.org>
136-Build-Depends: debhelper (>= 5), @bd_plugin@ openjdk-6-jdk (>= 6b23~pre10~), zip, lsb-release, libgtk2.0-dev, pkg-config, default-jre-headless
137+Build-Depends: debhelper (>= 5), @bd_plugin@ openjdk-7-jdk, zip, lsb-release, libgtk2.0-dev, pkg-config, default-jre-headless
138 Standards-Version: 3.9.3
139 Homepage: http://icedtea.classpath.org/wiki/IcedTea-Web
140 Vcs-Bzr: http://bazaar.launchpad.net/~openjdk/openjdk/icedtea-web
141@@ -12,7 +13,7 @@
142 Package: icedtea-netx
143 Architecture: any
144 Multi-Arch: same
145-Depends: ${netx:Depends}, openjdk-6-jre (>= 6b23~pre10~) | openjdk-7-jre, ${shlibs:Depends}, ${misc:Depends}
146+Depends: ${netx:Depends}, openjdk-7-jre | openjdk-6-jre (>= 6b23~pre10~), ${shlibs:Depends}, ${misc:Depends}
147 Conflicts: openjdk-6-jre (<< 6b18-1.8.7-3), openjdk-6-jre-headless (<< 6b18-1.8.7-3)
148 Replaces: openjdk-6-jre (<< 6b18-1.8.7-3), openjdk-6-jre-headless (<< 6b18-1.8.7-3)
149 Description: NetX - implementation of the Java Network Launching Protocol (JNLP)
150@@ -38,7 +39,7 @@
151 Package: icedtea-plugin
152 Section: web
153 Architecture: all
154-Depends: icedtea-6-plugin, ${misc:Depends}
155+Depends: icedtea-7-plugin, ${misc:Depends}
156 Description: web browser plugin to execute Java applets (dependency package)
157 IcedTeaPlugin is a web browser plugin to execute Java applets, supporting
158 LiveConnect/JavaScript. It is targeted for xulrunner-1.9 and compatible
159
160=== modified file 'debian/rules'
161--- debian/rules 2012-04-09 16:15:17 +0000
162+++ debian/rules 2012-07-11 10:11:44 +0000
163@@ -58,9 +58,7 @@
164 shortver = 6
165 last_npp_version = 6b18~pre2-2
166 priority = 1061
167-# not yet higher than for 6
168 priority7 = 1071
169-priority7 = 1060
170 plugin_name = IcedTeaPlugin.so
171
172 ifneq (,$(filter $(DEB_HOST_ARCH), alpha hppa sparc64)$(filter $(distrel), dapper))
173@@ -197,14 +195,14 @@
174 rm -rf build
175 mkdir -p build
176 cd build \
177- && ../configure $(CONFIGURE_ARGS) --with-jdk-home=/$(jdk_home)
178+ && ../configure $(CONFIGURE_ARGS) --with-jdk-home=/$(jdk7_home)
179 touch $@
180 configure7-stamp:
181 dh_testdir
182 rm -rf build7
183 mkdir -p build7
184 cd build7 \
185- && ../configure $(CONFIGURE_ARGS) --with-jdk-home=/$(jdk_home)
186+ && ../configure $(CONFIGURE_ARGS) --with-jdk-home=/$(jdk7_home)
187 touch $@
188
189 build-arch: build-stamp
190@@ -323,7 +321,7 @@
191 $(d_comm)/usr/share/applications/
192 cp -p debian/itweb-settings.desktop \
193 $(d_comm)/usr/share/applications/
194- for i in /usr/share/icons/hicolor/*/apps/openjdk-6.png; do \
195+ for i in /usr/share/icons/hicolor/*/apps/openjdk-7.png; do \
196 d=$$(dirname $$i); \
197 mkdir -p $(d_comm)/$$d; \
198 cp -p $$i $(d_comm)/$$d/javaws.png; \
199@@ -345,7 +343,7 @@
200 $(d_netx)/usr/share/applications/
201 cp -p debian/itweb-settings.desktop \
202 $(d_netx)/usr/share/applications/
203- for i in /usr/share/icons/hicolor/*/apps/openjdk-6.png; do \
204+ for i in /usr/share/icons/hicolor/*/apps/openjdk-7.png; do \
205 d=$$(dirname $$i); \
206 mkdir -p $(d_netx)/$$d; \
207 cp -p $$i $(d_netx)/$$d/javaws.png; \

Subscribers

People subscribed via source and target branches

to all changes: