Merge lp:~james-page/nova/fix-lxc-and-primary-group into lp:~ubuntu-server-dev/nova/diablo
Status: | Merged |
---|---|
Merged at revision: | 216 |
Proposed branch: | lp:~james-page/nova/fix-lxc-and-primary-group |
Merge into: | lp:~ubuntu-server-dev/nova/diablo |
Diff against target: |
48 lines (+20/-3) 2 files modified
debian/changelog (+9/-2) debian/nova-common.postinst (+11/-1) |
To merge this branch: | bzr merge lp:~james-page/nova/fix-lxc-and-primary-group |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Server Developers | 2011-09-28 | Pending | |
Review via email:
|
Description of the change
Fixup issues with primary group ownership of new files for upgraded nova installations
Ensure that ownership of files in LXC mounted volumes under /var/lib/nova do not get updated to nova:nova
Scott Moser (smoser) wrote : | # |
- 210. By James Page on 2011-09-28
-
Exclude mounted LXC rootfs filesystems within /var/lib/nova from
user/group ownership changes (LP: #861260). - 211. By James Page on 2011-09-28
-
tabs to spaces
Scott Moser (smoser) wrote : | # |
For reference, James and I had a long-ish conversation in ubuntu-server over this. It begins around 13:08.
http://
Dave Walker (davewalker) wrote : | # |
smoser / james: Did this progress?
Thanks
Chuck Short (zulcss) wrote : | # |
Any update on this?
- 212. By James Page on 2011-09-29
-
Updated to only run /var/lib/nova chown pre 0ubuntu4
- 213. By James Page on 2011-09-29
-
[James Page]
[Ante Karamatic]
* Add /usr/sbin/ietadm to sudoers (LP: #861547)
* debian/control: Fix typo in Vcs-Bzr
[Chuck Short]
* debian/patches/ backport- libvirt- console- pipe.patch:
Move console.log to a ringbuffer so that the console.log
keeps filling up. (LP: #832507)
* debian/patches/ backport- lxc-container- console- fix.patch:
Make euca-get-console- output usable for LXC containers.
(LP: #832159)
* debian/patches/ backport- snapshot- cleanup. patch: - 214. By James Page on 2011-09-29
-
Added quote to ensure works OK on first install
A couple thoughts on this
- I was initially confused about $(groups | awk '{print 3}) , as '3' seemed strange. groups does seem to output the primary group of a user as the first field, but I think that 'id -gn <user>' more explicitly requests that. I will admit to wishing the documentation for 'id' said "primary group" rather than just "effective group", but I looked at source and it does: 'rgid = egid = pwd->pw_gid;'.
I know this is nitpick.
- I'm concerned about the '-mount' argument to 'find'. filesystem /var/lib/ nova/instances nova/instances
If the user has done something like:
mount --bind /some/large/
or even:
mount /dev/sdb1 /var/lib/
I think that we'd avoid changing ownership of those files. I don't know how serious this is.
One quick fix I had would be to do this:
# change ownership of files under /var/lib/nova/ except rootfs (LP: #861260)
find /var/lib/nova/ -name 'rootfs' -prune -o -exec chown nova:nova {} \;