Merge lp:~james-page/juju-deployer/fixup-to-for-strings into lp:juju-deployer/darwin
Proposed by
James Page
Status: | Merged |
---|---|
Approved by: | Kapil Thangavelu |
Approved revision: | 118 |
Merge reported by: | Kapil Thangavelu |
Merged at revision: | not available |
Proposed branch: | lp:~james-page/juju-deployer/fixup-to-for-strings |
Merge into: | lp:juju-deployer/darwin |
Diff against target: |
21 lines (+2/-2) 1 file modified
deployer/env/base.py (+2/-2) |
To merge this branch: | bzr merge lp:~james-page/juju-deployer/fixup-to-for-strings |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kapil Thangavelu | Approve | ||
Adam Gandelman | Pending | ||
Review via email: mp+188296@code.launchpad.net |
This proposal supersedes a proposal from 2013-09-30.
Description of the change
Support use of string based machine identifiers in force-machine and
terminate-machine calls
To post a comment you must log in.
merged with minor change around the condition as it wouldn't work with mid = '0'. instead two separate clauses of the condition one with (mid.isdigit() and int(mid) == 0) to preserve original intent/behavior.