juju-deployer

Merge lp:~james-page/juju-deployer/add-machines-in-order into lp:juju-deployer

  1. add-machines-in-order
  2. Merge into trunk
Proposed by James Page
Status: Merged
Merged at revision: 193
Proposed branch: lp:~james-page/juju-deployer/add-machines-in-order
Merge into: lp:juju-deployer
Diff against target: 12 lines (+1/-1)
1 file modified
deployer/action/importer.py (+1/-1)
To merge this branch: bzr merge lp:~james-page/juju-deployer/add-machines-in-order
Reviewer Review Type Date Requested Status
Tim Van Steenburgh (community) Approve
Review via email: mp+306470@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

+1, thanks! Does this fix https://bugs.launchpad.net/juju-deployer/+bug/1625797 ?

review: Approve
Revision history for this message
James Page (james-page) wrote :

Unfortunately not.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'deployer/action/importer.py'
2--- deployer/action/importer.py 2016-07-12 23:43:08 +0000
3+++ deployer/action/importer.py 2016-09-22 14:23:58 +0000
4@@ -99,7 +99,7 @@
5
6 if machines:
7 self.log.info("Creating machines...")
8- for machine_name, spec in machines.items():
9+ for machine_name, spec in sorted(machines.items()):
10 if self.machine_exists(machine_name):
11 # XXX frankban: do we really want this? The machine
12 # identifiers as included in v4 bundles are not intended

Subscribers

People subscribed via source and target branches