Merge lp:~james-page/charms/trusty/swift-proxy/kilo into lp:~openstack-charmers-archive/charms/trusty/swift-proxy/next

Proposed by James Page
Status: Merged
Merged at revision: 87
Proposed branch: lp:~james-page/charms/trusty/swift-proxy/kilo
Merge into: lp:~openstack-charmers-archive/charms/trusty/swift-proxy/next
Diff against target: 174 lines (+128/-2)
5 files modified
hooks/charmhelpers/contrib/openstack/templates/section-keystone-authtoken (+9/-0)
hooks/charmhelpers/contrib/openstack/templates/section-rabbitmq-oslo (+22/-0)
hooks/charmhelpers/core/services/helpers.py (+2/-2)
hooks/swift_context.py (+2/-0)
templates/kilo/proxy-server.conf (+93/-0)
To merge this branch: bzr merge lp:~james-page/charms/trusty/swift-proxy/kilo
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+254054@code.launchpad.net
To post a comment you must log in.
89. By James Page

resync helpers

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2893 swift-proxy-next for james-page mp254054
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
  hooks/swift_context.py:145:51: E127 continuation line over-indented for visual indent
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/10676328/
Build: http://10.245.162.77:8080/job/charm_lint_check/2893/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #2684 swift-proxy-next for james-page mp254054
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2684/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #2691 swift-proxy-next for james-page mp254054
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 1
  make: *** [test] Error 1

Full amulet test output: http://paste.ubuntu.com/10676461/
Build: http://10.245.162.77:8080/job/charm_amulet_test/2691/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'hooks/charmhelpers/contrib/openstack/templates/section-keystone-authtoken'
2--- hooks/charmhelpers/contrib/openstack/templates/section-keystone-authtoken 1970-01-01 00:00:00 +0000
3+++ hooks/charmhelpers/contrib/openstack/templates/section-keystone-authtoken 2015-03-25 09:23:00 +0000
4@@ -0,0 +1,9 @@
5+{% if auth_host -%}
6+[keystone_authtoken]
7+identity_uri = {{ auth_protocol }}://{{ auth_host }}:{{ auth_port }}/{{ auth_admin_prefix }}
8+auth_uri = {{ service_protocol }}://{{ service_host }}:{{ service_port }}/{{ service_admin_prefix }}
9+admin_tenant_name = {{ admin_tenant_name }}
10+admin_user = {{ admin_user }}
11+admin_password = {{ admin_password }}
12+signing_dir = {{ signing_dir }}
13+{% endif -%}
14
15=== added file 'hooks/charmhelpers/contrib/openstack/templates/section-rabbitmq-oslo'
16--- hooks/charmhelpers/contrib/openstack/templates/section-rabbitmq-oslo 1970-01-01 00:00:00 +0000
17+++ hooks/charmhelpers/contrib/openstack/templates/section-rabbitmq-oslo 2015-03-25 09:23:00 +0000
18@@ -0,0 +1,22 @@
19+{% if rabbitmq_host or rabbitmq_hosts -%}
20+[oslo_messaging_rabbit]
21+rabbit_userid = {{ rabbitmq_user }}
22+rabbit_virtual_host = {{ rabbitmq_virtual_host }}
23+rabbit_password = {{ rabbitmq_password }}
24+{% if rabbitmq_hosts -%}
25+rabbit_hosts = {{ rabbitmq_hosts }}
26+{% if rabbitmq_ha_queues -%}
27+rabbit_ha_queues = True
28+rabbit_durable_queues = False
29+{% endif -%}
30+{% else -%}
31+rabbit_host = {{ rabbitmq_host }}
32+{% endif -%}
33+{% if rabbit_ssl_port -%}
34+rabbit_use_ssl = True
35+rabbit_port = {{ rabbit_ssl_port }}
36+{% if rabbit_ssl_ca -%}
37+kombu_ssl_ca_certs = {{ rabbit_ssl_ca }}
38+{% endif -%}
39+{% endif -%}
40+{% endif -%}
41
42=== modified file 'hooks/charmhelpers/core/services/helpers.py'
43--- hooks/charmhelpers/core/services/helpers.py 2015-03-04 09:54:42 +0000
44+++ hooks/charmhelpers/core/services/helpers.py 2015-03-25 09:23:00 +0000
45@@ -139,7 +139,7 @@
46
47 def __init__(self, *args, **kwargs):
48 self.required_keys = ['host', 'user', 'password', 'database']
49- super(HttpRelation).__init__(self, *args, **kwargs)
50+ RelationContext.__init__(self, *args, **kwargs)
51
52
53 class HttpRelation(RelationContext):
54@@ -154,7 +154,7 @@
55
56 def __init__(self, *args, **kwargs):
57 self.required_keys = ['host', 'port']
58- super(HttpRelation).__init__(self, *args, **kwargs)
59+ RelationContext.__init__(self, *args, **kwargs)
60
61 def provide_data(self):
62 return {
63
64=== modified file 'hooks/swift_context.py'
65--- hooks/swift_context.py 2015-03-13 13:02:08 +0000
66+++ hooks/swift_context.py 2015-03-25 09:23:00 +0000
67@@ -141,6 +141,8 @@
68 unit, relid) or 'http',
69 'keystone_host': relation_get('auth_host',
70 unit, relid),
71+ 'service_host': relation_get('service_host',
72+ unit, relid),
73 'auth_port': relation_get('auth_port',
74 unit, relid),
75 'service_user': relation_get('service_username',
76
77=== added directory 'templates/kilo'
78=== added file 'templates/kilo/proxy-server.conf'
79--- templates/kilo/proxy-server.conf 1970-01-01 00:00:00 +0000
80+++ templates/kilo/proxy-server.conf 2015-03-25 09:23:00 +0000
81@@ -0,0 +1,93 @@
82+[DEFAULT]
83+bind_port = {{ bind_port }}
84+workers = {{ workers }}
85+user = swift
86+bind_ip = {{ bind_host }}
87+{% if ssl %}
88+cert_file = {{ ssl_cert }}
89+key_file = {{ ssl_key }}
90+{% endif %}
91+
92+{% if auth_type == 'keystone' %}
93+[pipeline:main]
94+pipeline = gatekeeper healthcheck cache swift3 s3token container_sync bulk tempurl slo dlo formpost authtoken keystoneauth staticweb container-quotas account-quotas proxy-server
95+{% else %}
96+[pipeline:main]
97+pipeline = gatekeeper healthcheck cache container_sync bulk tempurl slo dlo formpost tempauth staticweb container-quotas account-quotas proxy-server
98+{% endif %}
99+
100+[app:proxy-server]
101+use = egg:swift#proxy
102+allow_account_management = true
103+{% if auth_type == 'keystone' %}account_autocreate = true{% endif %}
104+node_timeout = {{ node_timeout }}
105+recoverable_node_timeout = {{ recoverable_node_timeout }}
106+
107+[filter:tempauth]
108+use = egg:swift#tempauth
109+user_system_root = testpass .admin https://{{ proxy_ip }}:8080/v1/AUTH_system
110+
111+[filter:healthcheck]
112+use = egg:swift#healthcheck
113+
114+[filter:cache]
115+use = egg:swift#memcache
116+memcache_servers = {{ memcached_ip }}:11211
117+
118+[filter:account-quotas]
119+use = egg:swift#account_quotas
120+
121+[filter:container-quotas]
122+use = egg:swift#container_quotas
123+
124+[filter:staticweb]
125+use = egg:swift#staticweb
126+
127+[filter:bulk]
128+use = egg:swift#bulk
129+
130+[filter:slo]
131+use = egg:swift#slo
132+
133+[filter:dlo]
134+use = egg:swift#dlo
135+
136+[filter:formpost]
137+use = egg:swift#formpost
138+
139+[filter:tempurl]
140+use = egg:swift#tempurl
141+
142+[filter:container_sync]
143+use = egg:swift#container_sync
144+
145+[filter:gatekeeper]
146+use = egg:swift#gatekeeper
147+
148+{% if auth_type == 'keystone' %}
149+[filter:keystoneauth]
150+use = egg:swift#keystoneauth
151+operator_roles = {{ operator_roles }}
152+
153+[filter:authtoken]
154+paste.filter_factory = keystonemiddleware.auth_token:filter_factory
155+identity_uri = {{ auth_protocol }}://{{ keystone_host }}:{{ auth_port }}
156+auth_uri = {{ service_protocol }}://{{ service_host }}:{{ service_port }}
157+admin_tenant_name = {{ service_tenant }}
158+admin_user = {{ service_user }}
159+admin_password = {{ service_password }}
160+delay_auth_decision = {{ delay_auth_decision|lower }}
161+signing_dir = {{ signing_dir }}
162+cache = swift.cache
163+
164+[filter:s3token]
165+paste.filter_factory = keystonemiddleware.s3_token:filter_factory
166+identity_uri = {{ auth_protocol }}://{{ keystone_host }}:{{ auth_port }}
167+auth_uri = {{ service_protocol }}://{{ service_host }}:{{ service_port }}
168+admin_tenant_name = {{ service_tenant }}
169+admin_user = {{ service_user }}
170+admin_password = {{ service_password }}
171+
172+[filter:swift3]
173+use = egg:swift3#swift3
174+{% endif %}

Subscribers

People subscribed via source and target branches