Juju Charms Collection
rabbitmq-server package

Merge lp:~james-page/charms/trusty/rabbitmq-server/fixup-configure-nodename into lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next

  1. Trusty Tahr (14.04)
  2. fixup-configure-nodename
  3. Merge into next
Proposed by James Page on 2015-07-16
Status: Merged
Merged at revision: 99
Proposed branch: lp:~james-page/charms/trusty/rabbitmq-server/fixup-configure-nodename
Merge into: lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next
Diff against target: 12 lines (+2/-0)
1 file modified
hooks/rabbitmq_server_relations.py (+2/-0)
To merge this branch: bzr merge lp:~james-page/charms/trusty/rabbitmq-server/fixup-configure-nodename
Reviewer Review Type Date Requested Status
charmers 2015-07-16 Pending
Review via email: mp+265001@code.launchpad.net

This proposal supersedes a proposal from 2015-07-16.

Description of the Change

Fixup missing configuration of local nodename, causing problems when forward/reverse dns is broken.

To post a comment you must log in.
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #6278 rabbitmq-server-next for james-page mp265001
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6278/

uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #5910 rabbitmq-server-next for james-page mp265001
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5910/

uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5132 rabbitmq-server-next for james-page mp265001
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/11888130/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5132/

uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #5912 rabbitmq-server-next for james-page mp265001
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5912/

uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #6280 rabbitmq-server-next for james-page mp265001
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6280/

Ryan Beisner (1chb1n) wrote :

Tested this with the same scenario, and it fails at the same place.

Ref: https://launchpad.net/bugs/1475320

uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5134 rabbitmq-server-next for james-page mp265001
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/11888368/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5134/

Ryan Beisner (1chb1n) wrote :

Please see the following proposal which resolves the deploy issues we were seeing in lxc on baremetal:

https://code.launchpad.net/~1chb1n/charms/trusty/rabbitmq-server/fixup-configure-nodename2/+merge/265037

PS thanks for the jump start.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/rabbitmq_server_relations.py'
2--- hooks/rabbitmq_server_relations.py 2015-05-11 08:03:57 +0000
3+++ hooks/rabbitmq_server_relations.py 2015-07-16 14:33:52 +0000
4@@ -279,6 +279,8 @@
5 'rabbitmq cluster config.')
6 return
7
8+ configure_nodename()
9+
10 try:
11 if not is_leader():
12 log('Not the leader, deferring cookie propagation to leader')

Subscribers

People subscribed via source and target branches