Merge lp:~james-page/charms/trusty/quantum-gateway/kilo-support into lp:~openstack-charmers/charms/trusty/quantum-gateway/next

Proposed by James Page
Status: Merged
Merged at revision: 82
Proposed branch: lp:~james-page/charms/trusty/quantum-gateway/kilo-support
Merge into: lp:~openstack-charmers/charms/trusty/quantum-gateway/next
Diff against target: 118 lines (+68/-8)
6 files modified
hooks/quantum_utils.py (+11/-8)
templates/kilo/fwaas_driver.ini (+7/-0)
templates/kilo/lbaas_agent.ini (+8/-0)
templates/kilo/nova.conf (+29/-0)
templates/kilo/vpn_agent.ini (+8/-0)
unit_tests/test_quantum_utils.py (+5/-0)
To merge this branch: bzr merge lp:~james-page/charms/trusty/quantum-gateway/kilo-support
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+247105@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #954 quantum-gateway-next for james-page mp247105
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/954/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #925 quantum-gateway-next for james-page mp247105
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
  hooks/quantum_utils.py:170:80: E501 line too long (80 > 79 characters)
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/9803678/
Build: http://10.245.162.77:8080/job/charm_lint_check/925/

83. By James Page

Fixup lint

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #1147 quantum-gateway-next for james-page mp247105
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1147/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #928 quantum-gateway-next for james-page mp247105
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/928/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #957 quantum-gateway-next for james-page mp247105
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/957/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #1150 quantum-gateway-next for james-page mp247105
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1150/

84. By James Page

Add nova template for kilo

85. By James Page

Move options around a bit

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #933 quantum-gateway-next for james-page mp247105
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/933/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #962 quantum-gateway-next for james-page mp247105
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/962/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #1155 quantum-gateway-next for james-page mp247105
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1155/

Revision history for this message
Liam Young (gnuoy) wrote :

approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/quantum_utils.py'
2--- hooks/quantum_utils.py 2015-01-09 14:35:59 +0000
3+++ hooks/quantum_utils.py 2015-01-21 12:15:21 +0000
4@@ -163,14 +163,17 @@
5 '''Return a list of packages for install based on the configured plugin'''
6 plugin = remap_plugin(config('plugin'))
7 packages = deepcopy(GATEWAY_PKGS[networking_name()][plugin])
8- if (get_os_codename_install_source(config('openstack-origin'))
9- >= 'icehouse' and plugin == 'ovs'
10- and lsb_release()['DISTRIB_CODENAME'] < 'utopic'):
11- # NOTE(jamespage) neutron-vpn-agent supercedes l3-agent for icehouse
12- # but openswan was removed in utopic.
13- packages.remove('neutron-l3-agent')
14- packages.append('neutron-vpn-agent')
15- packages.append('openswan')
16+ source = get_os_codename_install_source(config('openstack-origin'))
17+ if plugin == 'ovs':
18+ if (source >= 'icehouse' and
19+ lsb_release()['DISTRIB_CODENAME'] < 'utopic'):
20+ # NOTE(jamespage) neutron-vpn-agent supercedes l3-agent for
21+ # icehouse but openswan was removed in utopic.
22+ packages.remove('neutron-l3-agent')
23+ packages.append('neutron-vpn-agent')
24+ packages.append('openswan')
25+ if source >= 'kilo':
26+ packages.append('python-neutron-fwaas')
27 return packages
28
29
30
31=== added directory 'templates/kilo'
32=== added file 'templates/kilo/fwaas_driver.ini'
33--- templates/kilo/fwaas_driver.ini 1970-01-01 00:00:00 +0000
34+++ templates/kilo/fwaas_driver.ini 2015-01-21 12:15:21 +0000
35@@ -0,0 +1,7 @@
36+###############################################################################
37+# [ WARNING ]
38+# Configuration file maintained by Juju. Local changes may be overwritten.
39+###############################################################################
40+[fwaas]
41+driver = neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver
42+enabled = True
43
44=== added file 'templates/kilo/lbaas_agent.ini'
45--- templates/kilo/lbaas_agent.ini 1970-01-01 00:00:00 +0000
46+++ templates/kilo/lbaas_agent.ini 2015-01-21 12:15:21 +0000
47@@ -0,0 +1,8 @@
48+[DEFAULT]
49+periodic_interval = 10
50+interface_driver = neutron.agent.linux.interface.OVSInterfaceDriver
51+ovs_use_veth = False
52+device_driver = neutron_lbaas.services.loadbalancer.drivers.haproxy.namespace_driver.HaproxyNSDriver
53+[haproxy]
54+loadbalancer_state_path = $state_path/lbaas
55+user_group = nogroup
56
57=== added file 'templates/kilo/nova.conf'
58--- templates/kilo/nova.conf 1970-01-01 00:00:00 +0000
59+++ templates/kilo/nova.conf 2015-01-21 12:15:21 +0000
60@@ -0,0 +1,29 @@
61+# kilo
62+###############################################################################
63+# [ WARNING ]
64+# Configuration file maintained by Juju. Local changes may be overwritten.
65+###############################################################################
66+[DEFAULT]
67+logdir=/var/log/nova
68+state_path=/var/lib/nova
69+lock_path=/var/lock/nova
70+root_helper=sudo nova-rootwrap /etc/nova/rootwrap.conf
71+verbose= {{ verbose }}
72+use_syslog = {{ use_syslog }}
73+api_paste_config=/etc/nova/api-paste.ini
74+enabled_apis=metadata
75+multi_host=True
76+{% include "parts/database" %}
77+# Access to message bus
78+{% include "parts/rabbitmq" %}
79+# Access to neutron API services
80+network_api_class=nova.network.neutronv2.api.API
81+[neutron]
82+auth_strategy=keystone
83+url={{ quantum_url }}
84+admin_tenant_name={{ service_tenant }}
85+admin_username={{ service_username }}
86+admin_password={{ service_password }}
87+admin_auth_url={{ service_protocol }}://{{ keystone_host }}:{{ service_port }}/v2.0
88+service_metadata_proxy=True
89+metadata_proxy_shared_secret={{ shared_secret }}
90
91=== added file 'templates/kilo/vpn_agent.ini'
92--- templates/kilo/vpn_agent.ini 1970-01-01 00:00:00 +0000
93+++ templates/kilo/vpn_agent.ini 2015-01-21 12:15:21 +0000
94@@ -0,0 +1,8 @@
95+###############################################################################
96+# [ WARNING ]
97+# Configuration file maintained by Juju. Local changes may be overwritten.
98+###############################################################################
99+[vpnagent]
100+vpn_device_driver=neutron_vpnaas.services.vpn.device_drivers.ipsec.OpenSwanDriver
101+[ipsec]
102+ipsec_status_check_interval=60
103
104=== modified file 'unit_tests/test_quantum_utils.py'
105--- unit_tests/test_quantum_utils.py 2014-11-24 09:34:05 +0000
106+++ unit_tests/test_quantum_utils.py 2015-01-21 12:15:21 +0000
107@@ -132,6 +132,11 @@
108 self.assertTrue('neutron-vpn-agent' in quantum_utils.get_packages())
109 self.assertFalse('neutron-l3-agent' in quantum_utils.get_packages())
110
111+ def test_get_packages_ovs_kilo(self):
112+ self.config.return_value = 'ovs'
113+ self.get_os_codename_install_source.return_value = 'kilo'
114+ self.assertTrue('python-neutron-fwaas' in quantum_utils.get_packages())
115+
116 def test_configure_ovs_starts_service_if_required(self):
117 self.config.return_value = 'ovs'
118 self.service_running.return_value = False

Subscribers

People subscribed via source and target branches