Merge lp:~james-page/charms/trusty/openstack-dashboard/xenial-support into lp:~openstack-charmers-archive/charms/trusty/openstack-dashboard/next

Proposed by James Page
Status: Merged
Merged at revision: 106
Proposed branch: lp:~james-page/charms/trusty/openstack-dashboard/xenial-support
Merge into: lp:~openstack-charmers-archive/charms/trusty/openstack-dashboard/next
Diff against target: 86 lines (+28/-9)
3 files modified
config.yaml (+0/-1)
hooks/horizon_utils.py (+4/-1)
templates/haproxy.cfg (+24/-7)
To merge this branch: bzr merge lp:~james-page/charms/trusty/openstack-dashboard/xenial-support
Reviewer Review Type Date Requested Status
David Ames (community) Approve
Review via email: mp+286508@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #742 openstack-dashboard-next for james-page mp286508
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/742/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #839 openstack-dashboard-next for james-page mp286508
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/839/

108. By James Page

Fixups

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #840 openstack-dashboard-next for james-page mp286508
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/15110975/
Build: http://10.245.162.36:8080/job/charm_lint_check/840/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #744 openstack-dashboard-next for james-page mp286508
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/15110980/
Build: http://10.245.162.36:8080/job/charm_unit_test/744/

109. By James Page

Rework to make testing easier

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #844 openstack-dashboard-next for james-page mp286508
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/844/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #747 openstack-dashboard-next for james-page mp286508
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/747/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #340 openstack-dashboard-next for james-page mp286508
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15112258/
Build: http://10.245.162.36:8080/job/charm_amulet_test/340/

110. By James Page

Disable wily-liberty for now

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #851 openstack-dashboard-next for james-page mp286508
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/851/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #754 openstack-dashboard-next for james-page mp286508
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/754/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #349 openstack-dashboard-next for james-page mp286508
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15117832/
Build: http://10.245.162.36:8080/job/charm_amulet_test/349/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #353 openstack-dashboard-next for james-page mp286508
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15125511/
Build: http://10.245.162.36:8080/job/charm_amulet_test/353/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #354 openstack-dashboard-next for james-page mp286508
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/354/

Revision history for this message
David Ames (thedac) wrote :

Looks good. Merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2015-12-03 22:54:20 +0000
3+++ config.yaml 2016-02-18 18:17:57 +0000
4@@ -217,4 +217,3 @@
5 description: |
6 Connect timeout configuration in ms for haproxy, used in HA
7 configurations. If not provided, default value of 5000ms is used.
8-
9
10=== modified file 'hooks/horizon_utils.py'
11--- hooks/horizon_utils.py 2015-10-10 23:18:23 +0000
12+++ hooks/horizon_utils.py 2016-02-18 18:17:57 +0000
13@@ -141,7 +141,10 @@
14 'services': ['apache2'],
15 }),
16 (HAPROXY_CONF, {
17- 'hook_contexts': [horizon_contexts.HorizonHAProxyContext()],
18+ 'hook_contexts': [
19+ horizon_contexts.HorizonHAProxyContext(),
20+ context.HAProxyContext(singlenode_mode=True),
21+ ],
22 'services': ['haproxy'],
23 }),
24 (ROUTER_SETTING, {
25
26=== modified file 'templates/haproxy.cfg'
27--- templates/haproxy.cfg 2015-01-21 21:53:06 +0000
28+++ templates/haproxy.cfg 2016-02-18 18:17:57 +0000
29@@ -1,6 +1,6 @@
30 global
31- log 127.0.0.1 local0
32- log 127.0.0.1 local1 notice
33+ log {{ local_host }} local0
34+ log {{ local_host }} local1 notice
35 maxconn 20000
36 user haproxy
37 group haproxy
38@@ -12,23 +12,40 @@
39 option tcplog
40 option dontlognull
41 retries 3
42- timeout queue 1000
43- timeout connect 1000
44+{%- if haproxy_queue_timeout %}
45+ timeout queue {{ haproxy_queue_timeout }}
46+{%- else %}
47+ timeout queue 5000
48+{%- endif %}
49+{%- if haproxy_connect_timeout %}
50+ timeout connect {{ haproxy_connect_timeout }}
51+{%- else %}
52+ timeout connect 5000
53+{%- endif %}
54+{%- if haproxy_client_timeout %}
55+ timeout client {{ haproxy_client_timeout }}
56+{%- else %}
57 timeout client 30000
58+{%- endif %}
59+{%- if haproxy_server_timeout %}
60+ timeout server {{ haproxy_server_timeout }}
61+{%- else %}
62 timeout server 30000
63+{%- endif %}
64
65-listen stats :8888
66+listen stats
67+ bind {{ local_host }}:{{ stat_port }}
68 mode http
69 stats enable
70 stats hide-version
71 stats realm Haproxy\ Statistics
72 stats uri /
73- stats auth admin:password
74+ stats auth admin:{{ stat_password }}
75
76 {% if units %}
77 {% for service, ports in service_ports.iteritems() -%}
78 listen {{ service }}
79- bind 0.0.0.0:{{ ports[0] }}
80+ bind *:{{ ports[0] }}
81 {% if prefer_ipv6 -%}
82 bind :::{{ ports[0] }}
83 {%- endif %}
84
85=== modified file 'tests/019-basic-trusty-mitaka' (properties changed: -x to +x)
86=== modified file 'tests/021-basic-xenial-mitaka' (properties changed: -x to +x)

Subscribers

People subscribed via source and target branches