Merge lp:~james-page/charms/trusty/nova-compute/neutron-plugin-sub-config into lp:~openstack-charmers-archive/charms/trusty/nova-compute/next

Proposed by James Page
Status: Merged
Merged at revision: 145
Proposed branch: lp:~james-page/charms/trusty/nova-compute/neutron-plugin-sub-config
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target: 42 lines (+7/-3)
3 files modified
hooks/charmhelpers/contrib/openstack/context.py (+0/-2)
hooks/nova_compute_context.py (+3/-1)
hooks/nova_compute_utils.py (+4/-0)
To merge this branch: bzr merge lp:~james-page/charms/trusty/nova-compute/neutron-plugin-sub-config
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+264854@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #6229 nova-compute-next for james-page mp264854
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6229/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #5861 nova-compute-next for james-page mp264854
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5861/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5128 nova-compute-next for james-page mp264854
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5128/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/charmhelpers/contrib/openstack/context.py'
2--- hooks/charmhelpers/contrib/openstack/context.py 2015-06-19 15:09:56 +0000
3+++ hooks/charmhelpers/contrib/openstack/context.py 2015-07-15 14:22:16 +0000
4@@ -891,8 +891,6 @@
5 return ctxt
6
7 def __call__(self):
8- self._ensure_packages()
9-
10 if self.network_manager not in ['quantum', 'neutron']:
11 return {}
12
13
14=== modified file 'hooks/nova_compute_context.py'
15--- hooks/nova_compute_context.py 2015-03-31 13:22:53 +0000
16+++ hooks/nova_compute_context.py 2015-07-15 14:22:16 +0000
17@@ -444,7 +444,9 @@
18 if not ovs_ctxt:
19 return {}
20
21- self._ensure_bridge()
22+ if config('manage-neutron-plugin-legacy-mode'):
23+ self._ensure_packages()
24+ self._ensure_bridge()
25
26 ovs_ctxt['local_ip'] = \
27 get_address_in_network(config('os-data-network'),
28
29=== modified file 'hooks/nova_compute_utils.py'
30--- hooks/nova_compute_utils.py 2015-05-12 19:53:02 +0000
31+++ hooks/nova_compute_utils.py 2015-07-15 14:22:16 +0000
32@@ -158,6 +158,10 @@
33 interface='nova-ceilometer',
34 service='nova',
35 config_file=NOVA_CONF),
36+ context.SubordinateConfigContext(
37+ interface='neutron-plugin',
38+ service='nova-compute',
39+ config_file=NOVA_CONF),
40 InstanceConsoleContext(),
41 context.ZeroMQContext(),
42 context.NotificationDriverContext(),

Subscribers

People subscribed via source and target branches