Merge lp:~james-page/charms/trusty/nova-compute/disable-neutron-security-option into lp:~openstack-charmers-archive/charms/trusty/nova-compute/trunk

Proposed by James Page
Status: Superseded
Proposed branch: lp:~james-page/charms/trusty/nova-compute/disable-neutron-security-option
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-compute/trunk
Diff against target: 26 lines (+8/-0)
2 files modified
config.yaml (+5/-0)
hooks/nova_compute_context.py (+3/-0)
To merge this branch: bzr merge lp:~james-page/charms/trusty/nova-compute/disable-neutron-security-option
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+221751@code.launchpad.net

This proposal has been superseded by a proposal from 2014-06-02.

Description of the change

Add option to allow the nova-compute charm to override neutron security group configuration provided from the nova-cloud-controller.

To post a comment you must log in.
65. By James Page

Do the disable a different way

66. By James Page

Put disable in the right place

67. By James Page

Add big warning

68. By James Page

Tidy lint, add unit tests

69. By James Page

Tidy test a bit

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-03-31 15:24:56 +0000
3+++ config.yaml 2014-06-02 15:40:29 +0000
4@@ -105,3 +105,8 @@
5 juju-myservice-0
6 If you're running multiple environments with the same services in them
7 this allows you to differentiate between them.
8+ disable-neutron-security-groups:
9+ type: boolean
10+ description: |
11+ Disable neutron based security groups - setting this configuration option
12+ will override any settings configured via the nova-cloud-controller charm.
13
14=== modified file 'hooks/nova_compute_context.py'
15--- hooks/nova_compute_context.py 2014-04-04 16:45:38 +0000
16+++ hooks/nova_compute_context.py 2014-06-02 15:40:29 +0000
17@@ -48,6 +48,9 @@
18 Inspects current cloud-compute relation and determine if nova-c-c has
19 instructed us to use neutron security groups.
20 '''
21+ # NOTE(jamespage) support override of neutron security via config
22+ if config('disable-neutron-security-groups') is not None:
23+ return not config('disable-neutron-security-groups')
24 for rid in relation_ids('cloud-compute'):
25 for unit in related_units(rid):
26 groups = [

Subscribers

People subscribed via source and target branches