Merge lp:~james-page/charms/trusty/nova-cloud-controller/xenial into lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next

[James Page]

[lp:~james-page/charms/trusty/nova-cloud-controller/xenial]

226. By James Page on 2016-02-11

Enable testing of xenial

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #238 nova-cloud-controller-next for james-page mp285779
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/238/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #222 nova-cloud-controller-next for james-page mp285779
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/222/

[David Ames (thedac)]

Besides s/kilo/mitaka in the nova.conf template this looks good. Waiting for final amulet run.

review: Needs Fixing

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #117 nova-cloud-controller-next for james-page mp285779
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15019680/
Build: http://10.245.162.36:8080/job/charm_amulet_test/117/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #123 nova-cloud-controller-next for james-page mp285779
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15022745/
Build: http://10.245.162.36:8080/job/charm_amulet_test/123/

[lp:~james-page/charms/trusty/nova-cloud-controller/xenial]

227. By James Page on 2016-02-12

Fixup template header

228. By James Page on 2016-02-12

Drop tests for ec2 and objectstore on >= liberty

229. By James Page on 2016-02-12

Disable mitaka tests until all merges land

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #372 nova-cloud-controller-next for james-page mp285779
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/372/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #294 nova-cloud-controller-next for james-page mp285779
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/294/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #374 nova-cloud-controller-next for james-page mp285779
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/374/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #297 nova-cloud-controller-next for james-page mp285779
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/297/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #146 nova-cloud-controller-next for james-page mp285779
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15027227/
Build: http://10.245.162.36:8080/job/charm_amulet_test/146/

[David Ames (thedac)]

James,

This amulet fail is legit. The amulet test was changed

=== modified file 'tests/basic_deployment.py'
--- tests/basic_deployment.py 2015-10-16 05:41:09 +0000
+++ tests/basic_deployment.py 2016-02-12 21:25:26 +0000
@@ -195,6 +195,9 @@
             self.keystone_sentry: ['keystone'],
             self.glance_sentry: ['glance-registry', 'glance-api']
         }
+ if self._get_openstack_release_string() >= 'liberty':
+ services[self.nova_cc_sentry].remove('nova-api-ec2')
+ services[self.nova_cc_sentry].remove('nova-objectstore')

That is what is failing:
2016-02-12 17:34:18,008 service_restarted_since DEBUG: Checking that nova-api-ec2 service restarted since 1455298326.0 on nova-cloud-controller/0
nova-cloud-controller/0 `pidof -x nova-api-ec2` returned 1

juju-test.conductor.018-basic-trusty-liberty DEBUG : Got exit code: 1
juju-test.conductor.018-basic-trusty-liberty RESULT : FAIL

review: Needs Fixing

[lp:~james-page/charms/trusty/nova-cloud-controller/xenial]

230. By James Page on 2016-02-16

Drop ec2 and objectstore checks from restart tests for liberty or greater

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #664 nova-cloud-controller-next for james-page mp285779
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/664/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #574 nova-cloud-controller-next for james-page mp285779
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/574/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #666 nova-cloud-controller-next for james-page mp285779
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/666/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #576 nova-cloud-controller-next for james-page mp285779
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/576/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #271 nova-cloud-controller-next for james-page mp285779
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/271/

[Billy Olsen (billy-olsen)]

Looks sane to me.

review: Approve

=== modified file 'hooks/nova_cc_hooks.py'
--- hooks/nova_cc_hooks.py	2016-02-11 15:49:38 +0000
+++ hooks/nova_cc_hooks.py	2016-02-16 19:02:24 +0000
@@ -1067,8 +1067,8 @@
                 fp.write('manual\n')
                 fp.flush()
 
-    elif (not config('single-nova-consoleauth')
-          and console_attributes('protocol')):
+    elif (not config('single-nova-consoleauth') and
+          console_attributes('protocol')):
         for item in ['vip_consoleauth', 'res_nova_consoleauth']:
             if item not in data['delete_resources']:
                 data['delete_resources'].append(item)
 
=== modified file 'hooks/nova_cc_utils.py'
--- hooks/nova_cc_utils.py	2016-01-08 12:30:31 +0000
+++ hooks/nova_cc_utils.py	2016-02-16 19:02:24 +0000
@@ -162,6 +162,10 @@
     'nova-scheduler',
 ]
 
+SERVICE_BLACKLIST = {
+    'liberty': ['nova-api-ec2', 'nova-objectstore']
+}
+
 API_PORTS = {
     'nova-api-ec2': 8773,
     'nova-api-os-compute': 8774,
@@ -186,9 +190,20 @@
 NEUTRON_DEFAULT = '/etc/default/neutron-server'
 QUANTUM_DEFAULT = '/etc/default/quantum-server'
 
+
+def resolve_services():
+    _services = deepcopy(BASE_SERVICES)
+    os_rel = get_os_codename_install_source(config('openstack-origin'))
+    for release in SERVICE_BLACKLIST:
+        if os_rel >= release:
+            [_services.remove(service)
+             for service in SERVICE_BLACKLIST[release]]
+    return _services
+
+
 BASE_RESOURCE_MAP = OrderedDict([
     (NOVA_CONF, {
-        'services': BASE_SERVICES,
+        'services': resolve_services(),
         'contexts': [context.AMQPContext(ssl_dir=NOVA_CONF_DIR),
                      context.SharedDBContext(
                          relation_prefix='nova', ssl_dir=NOVA_CONF_DIR),
@@ -220,7 +235,7 @@
                      nova_cc_context.CloudComputeContext()],
     }),
     (NOVA_API_PASTE, {
-        'services': [s for s in BASE_SERVICES if 'api' in s],
+        'services': [s for s in resolve_services() if 'api' in s],
         'contexts': [nova_cc_context.IdentityServiceContext(),
                      nova_cc_context.APIRateLimitingContext()],
     }),
@@ -348,8 +363,7 @@
         if plugin:
             conf = neutron_plugin_attribute(plugin, 'config', net_manager)
             ctxts = (neutron_plugin_attribute(plugin, 'contexts',
-                                              net_manager)
-                     or [])
+                                              net_manager) or [])
             services = neutron_plugin_attribute(plugin, 'server_services',
                                                 net_manager)
             resource_map[conf] = {}
@@ -1010,7 +1024,7 @@
     '''Map of services and required interfaces that must be present before
     the service should be allowed to start'''
     gmap = {}
-    nova_services = deepcopy(BASE_SERVICES)
+    nova_services = resolve_services()
     if os_release('nova-common') not in ['essex', 'folsom']:
         nova_services.append('nova-conductor')
 
 
=== added file 'templates/mitaka/nova.conf'
--- templates/mitaka/nova.conf	1970-01-01 00:00:00 +0000
+++ templates/mitaka/nova.conf	2016-02-16 19:02:24 +0000
@@ -0,0 +1,174 @@
+# mitaka
+###############################################################################
+# [ WARNING ]
+# Configuration file maintained by Juju. Local changes may be overwritten.
+###############################################################################
+[DEFAULT]
+verbose={{ verbose }}
+debug={{ debug }}
+dhcpbridge_flagfile=/etc/nova/nova.conf
+dhcpbridge=/usr/bin/nova-dhcpbridge
+logdir=/var/log/nova
+state_path=/var/lib/nova
+force_dhcp_release=True
+iscsi_helper=tgtadm
+libvirt_use_virtio_for_bridges=True
+connection_type=libvirt
+root_helper=sudo nova-rootwrap /etc/nova/rootwrap.conf
+ec2_private_dns_show_ip=True
+api_paste_config=/etc/nova/api-paste.ini
+volumes_path=/var/lib/nova/volumes
+enabled_apis=ec2,osapi_compute,metadata
+auth_strategy=keystone
+compute_driver=libvirt.LibvirtDriver
+use_ipv6 = {{ use_ipv6 }}
+osapi_compute_listen = {{ bind_host }}
+metadata_host = {{ bind_host }}
+s3_listen = {{ bind_host }}
+ec2_listen = {{ bind_host }}
+
+osapi_compute_workers = {{ workers }}
+ec2_workers = {{ workers }}
+
+scheduler_default_filters = {{ scheduler_default_filters }}
+cpu_allocation_ratio = {{ cpu_allocation_ratio }}
+ram_allocation_ratio = {{ ram_allocation_ratio }}
+
+use_syslog={{ use_syslog }}
+my_ip = {{ host_ip }}
+
+{% if memcached_servers %}
+memcached_servers = {{ memcached_servers }}
+{% endif %}
+
+{% include "parts/novnc" %}
+
+{% if keystone_ec2_url -%}
+keystone_ec2_url = {{ keystone_ec2_url }}
+{% endif -%}
+
+{% if rbd_pool -%}
+rbd_pool = {{ rbd_pool }}
+rbd_user = {{ rbd_user }}
+rbd_secret_uuid = {{ rbd_secret_uuid }}
+{% endif -%}
+
+{% if neutron_plugin and neutron_plugin == 'ovs' -%}
+libvirt_vif_driver = nova.virt.libvirt.vif.LibvirtGenericVIFDriver
+libvirt_user_virtio_for_bridges =  True
+{% if neutron_security_groups -%}
+security_group_api = {{ network_manager }}
+nova_firewall_driver = nova.virt.firewall.NoopFirewallDriver
+{% endif -%}
+{% if external_network -%}
+default_floating_pool = {{ external_network }}
+{% endif -%}
+{% endif -%}
+
+{% if neutron_plugin and neutron_plugin == 'vsp' -%}
+neutron_ovs_bridge = alubr0
+{% endif -%}
+
+{% if neutron_plugin and neutron_plugin == 'nvp' -%}
+security_group_api = neutron
+nova_firewall_driver = nova.virt.firewall.NoopFirewallDriver
+{% if external_network -%}
+default_floating_pool = {{ external_network }}
+{% endif -%}
+{% endif -%}
+
+{% if neutron_plugin and neutron_plugin == 'Calico' -%}
+security_group_api = neutron
+nova_firewall_driver = nova.virt.firewall.NoopFirewallDriver
+{% endif -%}
+
+{% if neutron_plugin and neutron_plugin == 'plumgrid' -%}
+security_group_api=neutron
+firewall_driver = nova.virt.firewall.NoopFirewallDriver
+{% endif -%}
+
+{% if network_manager_config -%}
+{% for key, value in network_manager_config.iteritems() -%}
+{{ key }} = {{ value }}
+{% endfor -%}
+{% endif -%}
+
+{% if network_manager and network_manager == 'neutron' -%}
+network_api_class = nova.network.neutronv2.api.API
+{% else -%}
+network_manager = nova.network.manager.FlatDHCPManager
+{% endif -%}
+
+{% if default_floating_pool -%}
+default_floating_pool = {{ default_floating_pool }}
+{% endif -%}
+
+{% if volume_service -%}
+volume_api_class=nova.volume.cinder.API
+{% endif -%}
+
+{% if user_config_flags -%}
+{% for key, value in user_config_flags.iteritems() -%}
+{{ key }} = {{ value }}
+{% endfor -%}
+{% endif -%}
+
+{% if listen_ports -%}
+{% for key, value in listen_ports.iteritems() -%}
+{{ key }} = {{ value }}
+{% endfor -%}
+{% endif -%}
+
+{% if sections and 'DEFAULT' in sections -%}
+{% for key, value in sections['DEFAULT'] -%}
+{{ key }} = {{ value }}
+{% endfor -%}
+{% endif %}
+
+{% include "section-zeromq" %}
+
+{% include "parts/database-v2" %}
+
+{% if glance_api_servers -%}
+[glance]
+api_servers = {{ glance_api_servers }}
+{% endif -%}
+
+{% if network_manager and network_manager == 'neutron' -%}
+[neutron]
+url = {{ neutron_url }}
+{% if auth_host -%}
+auth_plugin = password
+project_name = {{ admin_tenant_name }}
+username = {{ admin_user }}
+password = {{ admin_password }}
+auth_url = {{ auth_protocol }}://{{ auth_host }}:{{ auth_port }}
+region = {{ region }}
+{% endif -%}
+{% endif -%}
+
+[keystone_authtoken]
+{% if auth_host -%}
+auth_type = password
+project_name = {{ admin_tenant_name }}
+username = {{ admin_user }}
+password = {{ admin_password }}
+auth_url = {{ auth_protocol }}://{{ auth_host }}:{{ auth_port }}
+region = {{ region }}
+{% endif -%}
+
+[osapi_v3]
+enabled=True
+
+{% include "parts/cell" %}
+
+[conductor]
+workers = {{ workers }}
+
+{% include "section-rabbitmq-oslo" %}
+
+[oslo_concurrency]
+lock_path=/var/lock/nova
+
+[spice]
+{% include "parts/spice" %}
 
=== modified file 'tests/basic_deployment.py'
--- tests/basic_deployment.py	2015-10-16 05:41:09 +0000
+++ tests/basic_deployment.py	2016-02-16 19:02:24 +0000
@@ -195,6 +195,9 @@
             self.keystone_sentry: ['keystone'],
             self.glance_sentry: ['glance-registry', 'glance-api']
         }
+        if self._get_openstack_release_string() >= 'liberty':
+            services[self.nova_cc_sentry].remove('nova-api-ec2')
+            services[self.nova_cc_sentry].remove('nova-objectstore')
 
         ret = u.validate_services_by_name(services)
         if ret:
@@ -731,6 +734,10 @@
             'nova-conductor': conf_file
         }
 
+        if self._get_openstack_release_string() >= 'liberty':
+            del services['nova-api-ec2']
+            del services['nova-objectstore']
+
         # Expected default and alternate values
         flags_default = 'quota_cores=20,quota_instances=40,quota_ram=102400'
         flags_alt = 'quota_cores=10,quota_instances=20,quota_ram=51200'
 
=== modified file 'unit_tests/test_nova_cc_utils.py'
--- unit_tests/test_nova_cc_utils.py	2015-10-06 08:37:21 +0000
+++ unit_tests/test_nova_cc_utils.py	2016-02-16 19:02:24 +0000
@@ -794,6 +794,7 @@
         self.relation_ids.return_value = []
         self.network_manager.return_value = 'neutron'
         self.os_release.return_value = 'icehouse'
+        self.get_os_codename_install_source.return_value = 'icehouse'
         self.is_relation_made.return_value = False
         self.assertEqual(
             {'neutron-server': ['identity-service', 'amqp', 'shared-db'],
@@ -807,6 +808,7 @@
         )
         self.network_manager.return_value = 'quantum'
         self.os_release.return_value = 'grizzly'
+        self.get_os_codename_install_source.return_value = 'grizzly'
         self.assertEqual(
             {'quantum-server': ['identity-service', 'amqp', 'shared-db'],
              'nova-api-ec2': ['identity-service', 'amqp', 'shared-db'],
@@ -817,6 +819,17 @@
              'nova-scheduler': ['identity-service', 'amqp', 'shared-db'], },
             utils.guard_map()
         )
+        self.network_manager.return_value = 'neutron'
+        self.os_release.return_value = 'mitaka'
+        self.get_os_codename_install_source.return_value = 'mitaka'
+        self.assertEqual(
+            {'neutron-server': ['identity-service', 'amqp', 'shared-db'],
+             'nova-api-os-compute': ['identity-service', 'amqp', 'shared-db'],
+             'nova-cert': ['identity-service', 'amqp', 'shared-db'],
+             'nova-conductor': ['identity-service', 'amqp', 'shared-db'],
+             'nova-scheduler': ['identity-service', 'amqp', 'shared-db'], },
+            utils.guard_map()
+        )
 
     def test_guard_map_pgsql(self):
         self.relation_ids.return_value = ['pgsql:1']