Merge lp:~james-page/charms/trusty/nova-cloud-controller/wily into lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next

Proposed by James Page
Status: Merged
Merged at revision: 190
Proposed branch: lp:~james-page/charms/trusty/nova-cloud-controller/wily
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next
Diff against target: 40 lines (+21/-1)
2 files modified
hooks/install (+20/-0)
hooks/nova_cc_hooks.py (+1/-1)
To merge this branch: bzr merge lp:~james-page/charms/trusty/nova-cloud-controller/wily
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+271976@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10444 nova-cloud-controller-next for james-page mp271976
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10444/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9637 nova-cloud-controller-next for james-page mp271976
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9637/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6590 nova-cloud-controller-next for james-page mp271976
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12523571/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6590/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified symlink 'hooks/install' (properties changed: -x to +x)
2=== target was u'nova_cc_hooks.py'
3--- hooks/install 1970-01-01 00:00:00 +0000
4+++ hooks/install 2015-09-22 14:24:39 +0000
5@@ -0,0 +1,20 @@
6+#!/bin/bash
7+# Wrapper to deal with newer Ubuntu versions that don't have py2 installed
8+# by default.
9+
10+declare -a DEPS=('apt' 'netaddr' 'netifaces' 'pip' 'yaml')
11+
12+check_and_install() {
13+ pkg="${1}-${2}"
14+ if ! dpkg -s ${pkg} 2>&1 > /dev/null; then
15+ apt-get -y install ${pkg}
16+ fi
17+}
18+
19+PYTHON="python"
20+
21+for dep in ${DEPS[@]}; do
22+ check_and_install ${PYTHON} ${dep}
23+done
24+
25+exec ./hooks/install.real
26
27=== added symlink 'hooks/install.real'
28=== target is u'nova_cc_hooks.py'
29=== modified file 'hooks/nova_cc_hooks.py'
30--- hooks/nova_cc_hooks.py 2015-08-25 13:42:14 +0000
31+++ hooks/nova_cc_hooks.py 2015-09-22 14:24:39 +0000
32@@ -144,7 +144,7 @@
33 NOVA_CONSOLEAUTH_OVERRIDE = '/etc/init/nova-consoleauth.override'
34
35
36-@hooks.hook()
37+@hooks.hook('install.real')
38 def install():
39 execd_preinstall()
40 configure_installation_source(config('openstack-origin'))

Subscribers

People subscribed via source and target branches