Merge lp:~james-page/charms/trusty/neutron-agents-midonet/trunk into lp:~celebdor/charms/trusty/neutron-agents-midonet/trunk

Proposed by James Page
Status: Merged
Approved by: Antoni Segura Puimedon
Approved revision: 51
Merged at revision: 51
Proposed branch: lp:~james-page/charms/trusty/neutron-agents-midonet/trunk
Merge into: lp:~celebdor/charms/trusty/neutron-agents-midonet/trunk
Diff against target: 132 lines (+21/-35)
6 files modified
tests/006-minimal-trusty-kilo-mem (+1/-1)
tests/010-basic-trusty-juno (+1/-1)
tests/011-basic-trusty-kilo (+1/-1)
tests/012-basic-trusty-liberty (+1/-1)
tests/basic_deployment.py (+15/-16)
unit_tests/test_context.py (+2/-15)
To merge this branch: bzr merge lp:~james-page/charms/trusty/neutron-agents-midonet/trunk
Reviewer Review Type Date Requested Status
Antoni Segura Puimedon Pending
Review via email: mp+286181@code.launchpad.net

This proposal supersedes a proposal from 2016-02-16.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/00-setup' (properties changed: +x to -x)
=== modified file 'tests/006-minimal-trusty-kilo-mem'
--- tests/006-minimal-trusty-kilo-mem 2016-02-12 00:39:19 +0000
+++ tests/006-minimal-trusty-kilo-mem 2016-02-16 14:29:04 +0000
@@ -1,4 +1,4 @@
1#!/usr/bin/python1#!/usr/bin/env python
2#2#
3# Copyright (c) 2015 Midokura SARL, All Rights Reserved.3# Copyright (c) 2015 Midokura SARL, All Rights Reserved.
4#4#
55
=== modified file 'tests/010-basic-trusty-juno'
--- tests/010-basic-trusty-juno 2016-02-12 00:39:19 +0000
+++ tests/010-basic-trusty-juno 2016-02-16 14:29:04 +0000
@@ -1,4 +1,4 @@
1#!/usr/bin/python1#!/usr/bin/env python
2#2#
3# Copyright (c) 2015 Midokura SARL, All Rights Reserved.3# Copyright (c) 2015 Midokura SARL, All Rights Reserved.
4#4#
55
=== modified file 'tests/011-basic-trusty-kilo'
--- tests/011-basic-trusty-kilo 2016-02-12 00:39:19 +0000
+++ tests/011-basic-trusty-kilo 2016-02-16 14:29:04 +0000
@@ -1,4 +1,4 @@
1#!/usr/bin/python1#!/usr/bin/env python
2#2#
3# Copyright (c) 2015 Midokura SARL, All Rights Reserved.3# Copyright (c) 2015 Midokura SARL, All Rights Reserved.
4#4#
55
=== modified file 'tests/012-basic-trusty-liberty'
--- tests/012-basic-trusty-liberty 2016-02-12 00:39:19 +0000
+++ tests/012-basic-trusty-liberty 2016-02-16 14:29:04 +0000
@@ -1,4 +1,4 @@
1#!/usr/bin/python1#!/usr/bin/env python
2#2#
3# Copyright (c) 2015 Midokura SARL, All Rights Reserved.3# Copyright (c) 2015 Midokura SARL, All Rights Reserved.
4#4#
55
=== modified file 'tests/basic_deployment.py'
--- tests/basic_deployment.py 2016-02-12 00:39:19 +0000
+++ tests/basic_deployment.py 2016-02-16 14:29:04 +0000
@@ -31,7 +31,7 @@
31SETUP_TIMEOUT = 960031SETUP_TIMEOUT = 9600
3232
3333
34class ApiMinimumDeployment():34class AgentMinimumDeployment():
35 def __init__(self, ubuntu_series, openstack_origin=None,35 def __init__(self, ubuntu_series, openstack_origin=None,
36 midonet_origin=None):36 midonet_origin=None):
37 self.os_release = openstack_origin37 self.os_release = openstack_origin
@@ -60,29 +60,28 @@
60 self._initialize_tests()60 self._initialize_tests()
6161
62 def _add_services(self):62 def _add_services(self):
63 self.d.add('mysql', charm='cs:trusty/mysql', units=1,63 self.d.add('mysql', charm='mysql', units=1,
64 series=self.series)64 series=self.series)
65 self.d.add('keystone', charm='keystone', units=1, series=self.series,65 self.d.add('keystone', charm='keystone', units=1, series=self.series)
66 branch='cs:trusty/keystone')66 self.d.add('cassandra', charm='cassandra',
67 self.d.add('cassandra', charm='cs:trusty/cassandra',
68 units=1, series=self.series)67 units=1, series=self.series)
69 self.d.add('zookeeper', charm='cs:trusty/zookeeper', units=1,68 self.d.add('zookeeper', charm='zookeeper', units=1,
70 series=self.series)69 series=self.series)
71 self.d.add('rabbitmq', charm='cs:trusty/rabbitmq-server', units=1,70 self.d.add('rabbitmq', charm='rabbitmq-server', units=1,
72 series=self.series)71 series=self.series)
73 self.d.add('nova', charm='cs:trusty/nova-cloud-controller', units=1,72 self.d.add('nova', charm='nova-cloud-controller', units=1,
74 series=self.series)73 series=self.series)
75 self.d.add(74 self.d.add('neutron',
76 'neutron', charm='neutron-api', units=1,75 charm='cs:~openstack-charmers-next/trusty/neutron-api',
77 branch='lp:~openstack-charmers/charms/trusty/neutron-api/next',76 units=1,
78 series=self.series)77 series=self.series)
79 self.d.add('midonet-api', charm='midonet-api',78 self.d.add('midonet-api', charm='midonet-api',
80 branch='lp:~celebdor/charms/trusty/midonet-api/trunk',79 branch='lp:~celebdor/charms/trusty/midonet-api/trunk',
81 series=self.series)80 series=self.series)
82 self.d.add('midonet-agent', charm='midonet-agent',81 self.d.add('midonet-agent', charm='midonet-agent',
83 branch='lp:~celebdor/charms/trusty/midonet-agent/trunk',82 branch='lp:~celebdor/charms/trusty/midonet-agent/trunk',
84 series=self.series)83 series=self.series)
85 self.d.add('neutron-agents-midonet')84 self.d.add('neutron-agents-midonet', constraints={'mem': "4G"})
8685
87 def _add_relations(self):86 def _add_relations(self):
88 # Keystone87 # Keystone
8988
=== modified file 'unit_tests/test_context.py'
--- unit_tests/test_context.py 2016-02-11 13:12:41 +0000
+++ unit_tests/test_context.py 2016-02-16 14:29:04 +0000
@@ -60,28 +60,15 @@
60 test.CharmTestCase.setUp(self, services.hookenv, HOOKENV_PATCHES)60 test.CharmTestCase.setUp(self, services.hookenv, HOOKENV_PATCHES)
6161
62 def lsb_release():62 def lsb_release():
63 ubuntu_trusty = {63 return {
64 'DISTRIB_ID': 'Ubuntu',64 'DISTRIB_ID': 'Ubuntu',
65 'DISTRIB_RELEASE': '14.04',65 'DISTRIB_RELEASE': '14.04',
66 'DISTRIB_CODENAME': 'trusty',66 'DISTRIB_CODENAME': 'trusty',
67 'DISTRIB_DESCRIPTION': "Ubuntu 14.04.3 LTS",67 'DISTRIB_DESCRIPTION': "Ubuntu 14.04.3 LTS",
68 }68 }
6969
70 try:
71 data = services.host.lsb_release()
72 except Exception:
73 return ubuntu_trusty
74 if data.get('DISTRIB_ID') != 'Ubuntu':
75 return ubuntu_trusty
76 return data
77
78 def get_os_codename_package(pkg, fatal=True):70 def get_os_codename_package(pkg, fatal=True):
79 version = 'liberty'71 return 'liberty'
80 try:
81 ret_vers = services.utils.get_os_codename_package(pkg, fatal)
82 except Exception:
83 return version
84 return ret_vers
8572
86 self.patch_all(services.utils,73 self.patch_all(services.utils,
87 ('get_os_codename_package',74 ('get_os_codename_package',

Subscribers

People subscribed via source and target branches