Merge lp:~james-page/charms/trusty/neutron-agents-midonet/trunk into lp:~celebdor/charms/trusty/neutron-agents-midonet/trunk

Proposed by James Page
Status: Merged
Approved by: Antoni Segura Puimedon
Approved revision: 51
Merged at revision: 51
Proposed branch: lp:~james-page/charms/trusty/neutron-agents-midonet/trunk
Merge into: lp:~celebdor/charms/trusty/neutron-agents-midonet/trunk
Diff against target: 132 lines (+21/-35)
6 files modified
tests/006-minimal-trusty-kilo-mem (+1/-1)
tests/010-basic-trusty-juno (+1/-1)
tests/011-basic-trusty-kilo (+1/-1)
tests/012-basic-trusty-liberty (+1/-1)
tests/basic_deployment.py (+15/-16)
unit_tests/test_context.py (+2/-15)
To merge this branch: bzr merge lp:~james-page/charms/trusty/neutron-agents-midonet/trunk
Reviewer Review Type Date Requested Status
Antoni Segura Puimedon Pending
Review via email: mp+286181@code.launchpad.net

This proposal supersedes a proposal from 2016-02-16.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/00-setup' (properties changed: +x to -x)
2=== modified file 'tests/006-minimal-trusty-kilo-mem'
3--- tests/006-minimal-trusty-kilo-mem 2016-02-12 00:39:19 +0000
4+++ tests/006-minimal-trusty-kilo-mem 2016-02-16 14:29:04 +0000
5@@ -1,4 +1,4 @@
6-#!/usr/bin/python
7+#!/usr/bin/env python
8 #
9 # Copyright (c) 2015 Midokura SARL, All Rights Reserved.
10 #
11
12=== modified file 'tests/010-basic-trusty-juno'
13--- tests/010-basic-trusty-juno 2016-02-12 00:39:19 +0000
14+++ tests/010-basic-trusty-juno 2016-02-16 14:29:04 +0000
15@@ -1,4 +1,4 @@
16-#!/usr/bin/python
17+#!/usr/bin/env python
18 #
19 # Copyright (c) 2015 Midokura SARL, All Rights Reserved.
20 #
21
22=== modified file 'tests/011-basic-trusty-kilo'
23--- tests/011-basic-trusty-kilo 2016-02-12 00:39:19 +0000
24+++ tests/011-basic-trusty-kilo 2016-02-16 14:29:04 +0000
25@@ -1,4 +1,4 @@
26-#!/usr/bin/python
27+#!/usr/bin/env python
28 #
29 # Copyright (c) 2015 Midokura SARL, All Rights Reserved.
30 #
31
32=== modified file 'tests/012-basic-trusty-liberty'
33--- tests/012-basic-trusty-liberty 2016-02-12 00:39:19 +0000
34+++ tests/012-basic-trusty-liberty 2016-02-16 14:29:04 +0000
35@@ -1,4 +1,4 @@
36-#!/usr/bin/python
37+#!/usr/bin/env python
38 #
39 # Copyright (c) 2015 Midokura SARL, All Rights Reserved.
40 #
41
42=== modified file 'tests/basic_deployment.py'
43--- tests/basic_deployment.py 2016-02-12 00:39:19 +0000
44+++ tests/basic_deployment.py 2016-02-16 14:29:04 +0000
45@@ -31,7 +31,7 @@
46 SETUP_TIMEOUT = 9600
47
48
49-class ApiMinimumDeployment():
50+class AgentMinimumDeployment():
51 def __init__(self, ubuntu_series, openstack_origin=None,
52 midonet_origin=None):
53 self.os_release = openstack_origin
54@@ -60,29 +60,28 @@
55 self._initialize_tests()
56
57 def _add_services(self):
58- self.d.add('mysql', charm='cs:trusty/mysql', units=1,
59+ self.d.add('mysql', charm='mysql', units=1,
60 series=self.series)
61- self.d.add('keystone', charm='keystone', units=1, series=self.series,
62- branch='cs:trusty/keystone')
63- self.d.add('cassandra', charm='cs:trusty/cassandra',
64+ self.d.add('keystone', charm='keystone', units=1, series=self.series)
65+ self.d.add('cassandra', charm='cassandra',
66 units=1, series=self.series)
67- self.d.add('zookeeper', charm='cs:trusty/zookeeper', units=1,
68- series=self.series)
69- self.d.add('rabbitmq', charm='cs:trusty/rabbitmq-server', units=1,
70- series=self.series)
71- self.d.add('nova', charm='cs:trusty/nova-cloud-controller', units=1,
72- series=self.series)
73- self.d.add(
74- 'neutron', charm='neutron-api', units=1,
75- branch='lp:~openstack-charmers/charms/trusty/neutron-api/next',
76- series=self.series)
77+ self.d.add('zookeeper', charm='zookeeper', units=1,
78+ series=self.series)
79+ self.d.add('rabbitmq', charm='rabbitmq-server', units=1,
80+ series=self.series)
81+ self.d.add('nova', charm='nova-cloud-controller', units=1,
82+ series=self.series)
83+ self.d.add('neutron',
84+ charm='cs:~openstack-charmers-next/trusty/neutron-api',
85+ units=1,
86+ series=self.series)
87 self.d.add('midonet-api', charm='midonet-api',
88 branch='lp:~celebdor/charms/trusty/midonet-api/trunk',
89 series=self.series)
90 self.d.add('midonet-agent', charm='midonet-agent',
91 branch='lp:~celebdor/charms/trusty/midonet-agent/trunk',
92 series=self.series)
93- self.d.add('neutron-agents-midonet')
94+ self.d.add('neutron-agents-midonet', constraints={'mem': "4G"})
95
96 def _add_relations(self):
97 # Keystone
98
99=== modified file 'unit_tests/test_context.py'
100--- unit_tests/test_context.py 2016-02-11 13:12:41 +0000
101+++ unit_tests/test_context.py 2016-02-16 14:29:04 +0000
102@@ -60,28 +60,15 @@
103 test.CharmTestCase.setUp(self, services.hookenv, HOOKENV_PATCHES)
104
105 def lsb_release():
106- ubuntu_trusty = {
107+ return {
108 'DISTRIB_ID': 'Ubuntu',
109 'DISTRIB_RELEASE': '14.04',
110 'DISTRIB_CODENAME': 'trusty',
111 'DISTRIB_DESCRIPTION': "Ubuntu 14.04.3 LTS",
112 }
113
114- try:
115- data = services.host.lsb_release()
116- except Exception:
117- return ubuntu_trusty
118- if data.get('DISTRIB_ID') != 'Ubuntu':
119- return ubuntu_trusty
120- return data
121-
122 def get_os_codename_package(pkg, fatal=True):
123- version = 'liberty'
124- try:
125- ret_vers = services.utils.get_os_codename_package(pkg, fatal)
126- except Exception:
127- return version
128- return ret_vers
129+ return 'liberty'
130
131 self.patch_all(services.utils,
132 ('get_os_codename_package',

Subscribers

People subscribed via source and target branches