Merge lp:~james-page/charms/trusty/keystone/stable-bug-1413862 into lp:~openstack-charmers-archive/charms/trusty/keystone/trunk

Proposed by James Page
Status: Merged
Merged at revision: 121
Proposed branch: lp:~james-page/charms/trusty/keystone/stable-bug-1413862
Merge into: lp:~openstack-charmers-archive/charms/trusty/keystone/trunk
Diff against target: 32 lines (+3/-3)
3 files modified
charm-helpers-hooks.yaml (+1/-1)
charm-helpers-tests.yaml (+1/-1)
hooks/charmhelpers/contrib/openstack/context.py (+1/-1)
To merge this branch: bzr merge lp:~james-page/charms/trusty/keystone/stable-bug-1413862
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+251900@code.launchpad.net

Commit message

Resync helpers to resolve race condition when access-network is set in mysql or percona-cluster charms

Description of the change

Resync helpers to resolve race condition when access-network is set in mysql or percona-cluster charms

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2477 keystone for james-page mp251900
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2477/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #2267 keystone for james-page mp251900
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2267/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #2350 keystone for james-page mp251900
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/2350/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charm-helpers-hooks.yaml'
2--- charm-helpers-hooks.yaml 2015-01-13 14:40:50 +0000
3+++ charm-helpers-hooks.yaml 2015-03-05 11:16:20 +0000
4@@ -1,4 +1,4 @@
5-branch: lp:charm-helpers
6+branch: lp:~openstack-charmers/charm-helpers/stable
7 destination: hooks/charmhelpers
8 include:
9 - core
10
11=== modified file 'charm-helpers-tests.yaml'
12--- charm-helpers-tests.yaml 2014-09-23 10:21:28 +0000
13+++ charm-helpers-tests.yaml 2015-03-05 11:16:20 +0000
14@@ -1,4 +1,4 @@
15-branch: lp:charm-helpers
16+branch: lp:~openstack-charmers/charm-helpers/stable
17 destination: tests/charmhelpers
18 include:
19 - contrib.amulet
20
21=== modified file 'hooks/charmhelpers/contrib/openstack/context.py'
22--- hooks/charmhelpers/contrib/openstack/context.py 2015-01-26 09:44:47 +0000
23+++ hooks/charmhelpers/contrib/openstack/context.py 2015-03-05 11:16:20 +0000
24@@ -191,7 +191,7 @@
25 unit=local_unit())
26 if set_hostname != access_hostname:
27 relation_set(relation_settings={hostname_key: access_hostname})
28- return ctxt # Defer any further hook execution for now....
29+ return None # Defer any further hook execution for now....
30
31 password_setting = 'password'
32 if self.relation_prefix:

Subscribers

People subscribed via source and target branches