Merge lp:~james-page/charms/trusty/glance/stable-bug-1413862 into lp:~openstack-charmers-archive/charms/trusty/glance/trunk

[James Page]

Resync helpers to resolve race condition when access-network is set in mysql or percona-cluster charms

Resync helpers to resolve race condition when access-network is set in mysql or percona-cluster charms

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #2476 glance for james-page mp251899
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2476/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #2266 glance for james-page mp251899
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/2266/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #2349 glance for james-page mp251899
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/2349/

[Liam Young (gnuoy)]

Approve

review: Approve

=== modified file 'charm-helpers-hooks.yaml'
--- charm-helpers-hooks.yaml	2015-01-13 14:38:31 +0000
+++ charm-helpers-hooks.yaml	2015-03-05 11:16:11 +0000
@@ -1,4 +1,4 @@
-branch: lp:charm-helpers
+branch: lp:~openstack-charmers/charm-helpers/stable
 destination: hooks/charmhelpers
 include:
     - core

=== modified file 'charm-helpers-tests.yaml'
--- charm-helpers-tests.yaml	2014-09-23 10:21:11 +0000
+++ charm-helpers-tests.yaml	2015-03-05 11:16:11 +0000
@@ -1,4 +1,4 @@
-branch: lp:charm-helpers
+branch: lp:~openstack-charmers/charm-helpers/stable
 destination: tests/charmhelpers
 include:
     - contrib.amulet

=== modified file 'hooks/charmhelpers/contrib/openstack/context.py'
--- hooks/charmhelpers/contrib/openstack/context.py	2015-01-26 09:45:23 +0000
+++ hooks/charmhelpers/contrib/openstack/context.py	2015-03-05 11:16:11 +0000
@@ -191,7 +191,7 @@
                                         unit=local_unit())
             if set_hostname != access_hostname:
                 relation_set(relation_settings={hostname_key: access_hostname})
-                return ctxt  # Defer any further hook execution for now....
+                return None  # Defer any further hook execution for now....
 
         password_setting = 'password'
         if self.relation_prefix:

=== modified file 'hooks/charmhelpers/core/sysctl.py'
--- hooks/charmhelpers/core/sysctl.py	2015-01-26 09:45:23 +0000
+++ hooks/charmhelpers/core/sysctl.py	2015-03-05 11:16:11 +0000
@@ -26,25 +26,31 @@
 from charmhelpers.core.hookenv import (
     log,
     DEBUG,
+    ERROR,
 )
 
 
 def create(sysctl_dict, sysctl_file):
     """Creates a sysctl.conf file from a YAML associative array
 
-    :param sysctl_dict: a dict of sysctl options eg { 'kernel.max_pid': 1337 }
-    :type sysctl_dict: dict
+    :param sysctl_dict: a YAML-formatted string of sysctl options eg "{ 'kernel.max_pid': 1337 }"
+    :type sysctl_dict: str
     :param sysctl_file: path to the sysctl file to be saved
     :type sysctl_file: str or unicode
     :returns: None
     """
-    sysctl_dict = yaml.load(sysctl_dict)
+    try:
+        sysctl_dict_parsed = yaml.safe_load(sysctl_dict)
+    except yaml.YAMLError:
+        log("Error parsing YAML sysctl_dict: {}".format(sysctl_dict),
+            level=ERROR)
+        return
 
     with open(sysctl_file, "w") as fd:
-        for key, value in sysctl_dict.items():
+        for key, value in sysctl_dict_parsed.items():
             fd.write("{}={}\n".format(key, value))
 
-    log("Updating sysctl_file: %s values: %s" % (sysctl_file, sysctl_dict),
+    log("Updating sysctl_file: %s values: %s" % (sysctl_file, sysctl_dict_parsed),
         level=DEBUG)
 
     check_call(["sysctl", "-p", sysctl_file])