Merge lp:~james-page/charms/trusty/cinder-ceph/tox into lp:~openstack-charmers-archive/charms/trusty/cinder-ceph/next

[James Page]

[Corey Bryant (corey.bryant)]

Code looks good and I ran tests successfully (tox, make lint/test, and a subset of amulet tests).

review: Approve

=== modified file '.bzrignore'
--- .bzrignore	2014-07-02 08:14:53 +0000
+++ .bzrignore	2015-11-03 14:17:23 +0000
@@ -1,2 +1,5 @@
 bin
 .coverage
+.testrepository
+.tox
+tags

=== added file '.testr.conf'
--- .testr.conf	1970-01-01 00:00:00 +0000
+++ .testr.conf	2015-11-03 14:17:23 +0000
@@ -0,0 +1,8 @@
+[DEFAULT]
+test_command=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
+             OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
+             OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-60} \
+             ${PYTHON:-python} -m subunit.run discover -t ./ ./unit_tests $LISTOPT $IDOPTION
+
+test_id_option=--load-list $IDFILE
+test_list_option=--list

=== added file 'requirements.txt'
--- requirements.txt	1970-01-01 00:00:00 +0000
+++ requirements.txt	2015-11-03 14:17:23 +0000
@@ -0,0 +1,11 @@
+# The order of packages is significant, because pip processes them in the order
+# of appearance. Changing the order has an impact on the overall integration
+# process, which may cause wedges in the gate later.
+PyYAML>=3.1.0
+simplejson>=2.2.0
+netifaces>=0.10.4
+netaddr>=0.7.12,!=0.7.16
+Jinja2>=2.6  # BSD License (3 clause)
+six>=1.9.0
+dnspython>=1.12.0
+psutil>=1.1.1,<2.0.0

=== added file 'test-requirements.txt'
--- test-requirements.txt	1970-01-01 00:00:00 +0000
+++ test-requirements.txt	2015-11-03 14:17:23 +0000
@@ -0,0 +1,8 @@
+# The order of packages is significant, because pip processes them in the order
+# of appearance. Changing the order has an impact on the overall integration
+# process, which may cause wedges in the gate later.
+coverage>=3.6
+mock>=1.2
+flake8>=2.2.4,<=2.4.1
+os-testr>=0.4.1
+charm-tools

=== modified file 'tests/basic_deployment.py'
--- tests/basic_deployment.py	2015-09-14 09:36:00 +0000
+++ tests/basic_deployment.py	2015-11-03 14:17:23 +0000
@@ -14,7 +14,6 @@
 from charmhelpers.contrib.openstack.amulet.utils import (
     OpenStackAmuletUtils,
     DEBUG,
-    #ERROR
 )
 
 # Use DEBUG to turn on debug logging
@@ -306,12 +305,15 @@
     def get_broker_response(self):
         broker_request = self.get_broker_request()
         response_key = "broker-rsp-cinder-ceph-0"
-        ceph_sentrys = [self.ceph0_sentry, self.ceph1_sentry, self.ceph2_sentry]
+        ceph_sentrys = [self.ceph0_sentry,
+                        self.ceph1_sentry,
+                        self.ceph2_sentry]
         for sentry in ceph_sentrys:
             relation_data = sentry.relation('client', 'cinder-ceph:ceph')
             if relation_data.get(response_key):
                 broker_response = json.loads(relation_data[response_key])
-                if broker_request['request-id'] == broker_response['request-id']:
+                if (broker_request['request-id'] ==
+                        broker_response['request-id']):
                     return broker_response
 
     def test_200_cinderceph_ceph_ceph_relation(self):
@@ -321,8 +323,10 @@
         relation = ['ceph', 'ceph:client']
 
         req = {
-           "api-version": 1,
-           "ops": [{"replicas": 3, "name": "cinder-ceph", "op": "create-pool"}]
+            "api-version": 1,
+            "ops": [{"replicas": 3,
+                     "name": "cinder-ceph",
+                     "op": "create-pool"}]
         }
         expected = {
             'private-address': u.valid_ip,
@@ -340,7 +344,6 @@
     def test_201_ceph_cinderceph_ceph_relation(self):
         u.log.debug('Checking ceph:client to cinder-ceph:ceph '
                     'relation data...')
-        response_key = "broker-rsp-cinder-ceph-0"
         ceph_unit = self.ceph0_sentry
         relation = ['client', 'cinder-ceph:ceph']
         expected = {
@@ -355,7 +358,8 @@
             amulet.raise_status(amulet.FAIL, msg=msg)
         broker_response = self.get_broker_response()
         if not broker_response or broker_response['exit-code'] != 0:
-            msg='Broker request invalid or failed: {}'.format(broker_response)
+            msg = ('Broker request invalid'
+                   ' or failed: {}'.format(broker_response))
             amulet.raise_status(amulet.FAIL, msg=msg)
 
     def test_202_cinderceph_cinder_backend_relation(self):

=== added file 'tox.ini'
--- tox.ini	1970-01-01 00:00:00 +0000
+++ tox.ini	2015-11-03 14:17:23 +0000
@@ -0,0 +1,29 @@
+[tox]
+envlist = lint,py27
+skipsdist = True
+
+[testenv]
+setenv = VIRTUAL_ENV={envdir}
+         PYTHONHASHSEED=0
+install_command =
+  pip install --allow-unverified python-apt {opts} {packages}
+commands = ostestr {posargs}
+
+[testenv:py27]
+basepython = python2.7
+deps = -r{toxinidir}/requirements.txt
+       -r{toxinidir}/test-requirements.txt
+
+[testenv:lint]
+basepython = python2.7
+deps = -r{toxinidir}/requirements.txt
+       -r{toxinidir}/test-requirements.txt
+commands = flake8 {posargs} hooks unit_tests tests
+           charm proof
+
+[testenv:venv]
+commands = {posargs}
+
+[flake8]
+ignore = E402,E226
+exclude = hooks/charmhelpers

=== modified file 'unit_tests/test_cinder_hooks.py'
--- unit_tests/test_cinder_hooks.py	2015-10-08 15:46:16 +0000
+++ unit_tests/test_cinder_hooks.py	2015-11-03 14:17:23 +0000
@@ -155,4 +155,4 @@
             backend_name='test',
             subordinate_configuration=json.dumps({'test': 1}),
             stateless=True,
-            )
+        )