Code review comment for lp:~james-page/charms/precise/ceph-osd/charm-helpers

Revision history for this message
Mark Mims (mark-mims) wrote :

Awesome... great direction.

Two requests for the future direction of this charm:

- consider refactoring $CHARM_DIR/hooks/hooks.py into $CHARM_DIR/lib/ceph_tools with accompanying unit-type $CHARM_DIR/lib/ceph_tools/tests where possible

- please think up some decent integration tests and add them into $CHARM_DIR/tests

Thanks!

review: Approve

« Back to merge proposal