Merge lp:~james-page/charm-helpers/handle-called-process-exception-for-git into lp:charm-helpers

[James Page]

Prior to the switch to executing git commands directly, any git errors where handled as UnhandledSource exceptions.

Restore this functionality to ensure that all handlers are tried for a given URL, even if its not a git repo.

[Liam Young (gnuoy)]

Approved

review: Approve

=== modified file 'charmhelpers/fetch/giturl.py'
--- charmhelpers/fetch/giturl.py	2016-01-08 14:55:15 +0000
+++ charmhelpers/fetch/giturl.py	2016-01-22 09:43:44 +0000
@@ -15,7 +15,7 @@
 # along with charm-helpers.  If not, see <http://www.gnu.org/licenses/>.
 
 import os
-from subprocess import check_call
+from subprocess import check_call, CalledProcessError
 from charmhelpers.fetch import (
     BaseFetchHandler,
     UnhandledSource,
@@ -63,6 +63,8 @@
                                     branch_name)
         try:
             self.clone(source, dest_dir, branch, depth)
+        except CalledProcessError as e:
+            raise UnhandledSource(e)
         except OSError as e:
             raise UnhandledSource(e.strerror)
         return dest_dir