Merge lp:~james-page/charm-helpers/follow-symlinks into lp:charm-helpers

[James Page]

The chownr function does not follow symlinks when walking a path, even
when follow_links is set to True.

Ensure that this value is propagated to os.walk, ensuring that targets
of symlinks within the path are also part of the fileset upon which
file permissions are changed.

=== modified file 'charmhelpers/core/host.py'
--- charmhelpers/core/host.py	2016-12-13 06:23:05 +0000
+++ charmhelpers/core/host.py	2017-01-07 16:36:06 +0000
@@ -686,7 +686,7 @@
     :param str path: The string path to start changing ownership.
     :param str owner: The owner string to use when looking up the uid.
     :param str group: The group string to use when looking up the gid.
-    :param bool follow_links: Also Chown links if True
+    :param bool follow_links: Also follow and chown links if True
     :param bool chowntopdir: Also chown path itself if True
     """
     uid = pwd.getpwnam(owner).pw_uid
@@ -700,7 +700,7 @@
         broken_symlink = os.path.lexists(path) and not os.path.exists(path)
         if not broken_symlink:
             chown(path, uid, gid)
-    for root, dirs, files in os.walk(path):
+    for root, dirs, files in os.walk(path, followlinks=follow_links):
         for name in dirs + files:
             full = os.path.join(root, name)
             broken_symlink = os.path.lexists(full) and not os.path.exists(full)