Merge lp:~james-page/charm-helpers/flush-after-grant into lp:charm-helpers

[James Page]

Ensure that priviledges are flushed after creating new grants

After new grants are created in the database, all priviledges should
be flushed to ensure that the new grants actually work.

See https://dev.mysql.com/doc/refman/5.7/en/privilege-changes.html
See bug 1513239.

[Charles Butler (lazypower)]

LGTM +1

review: Approve

=== modified file 'charmhelpers/contrib/database/mysql.py'
--- charmhelpers/contrib/database/mysql.py	2017-02-28 12:04:36 +0000
+++ charmhelpers/contrib/database/mysql.py	2017-03-02 11:27:57 +0000
@@ -142,6 +142,13 @@
         finally:
             cursor.close()
 
+    def flush_priviledges(self):
+        cursor = self.connection.cursor()
+        try:
+            cursor.execute("FLUSH PRIVILEGES")
+        finally:
+            cursor.close()
+
     def execute(self, sql):
         """Execute arbitary SQL against the database."""
         cursor = self.connection.cursor()
@@ -323,6 +330,7 @@
                 self.create_grant(database, username, remote_ip, password)
             else:
                 self.create_admin_grant(username, remote_ip, password)
+            self.flush_priviledges()
 
         return password