Merge lp:~james-page/charm-helpers/fixup_upstream_version into lp:charm-helpers

Proposed by James Page
Status: Merged
Merged at revision: 75
Proposed branch: lp:~james-page/charm-helpers/fixup_upstream_version
Merge into: lp:charm-helpers
Diff against target: 12 lines (+1/-1)
1 file modified
charmhelpers/contrib/openstack/utils.py (+1/-1)
To merge this branch: bzr merge lp:~james-page/charm-helpers/fixup_upstream_version
Reviewer Review Type Date Requested Status
Jacek Nykis (community) Approve
Review via email: mp+181840@code.launchpad.net

Description of the change

UpstreamVersion -> upstream_version (this did not work on saucy)

To post a comment you must log in.
Revision history for this message
Jacek Nykis (jacekn) wrote :

Works fine on precise and raring. This change should be safe.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/contrib/openstack/utils.py'
2--- charmhelpers/contrib/openstack/utils.py 2013-08-07 23:14:14 +0000
3+++ charmhelpers/contrib/openstack/utils.py 2013-08-23 14:14:23 +0000
4@@ -133,7 +133,7 @@
5 e = 'Could not determine version of uninstalled package: %s' % package
6 error_out(e)
7
8- vers = apt.UpstreamVersion(pkg.current_ver.ver_str)
9+ vers = apt.upstream_version(pkg.current_ver.ver_str)
10
11 try:
12 if 'swift' in pkg.name:

Subscribers

People subscribed via source and target branches