Merge lp:~james-page/charm-helpers/fix_canonical_url into lp:charm-helpers
Proposed by
James Page
Status: | Merged |
---|---|
Approved by: | Adam Gandelman |
Approved revision: | 62 |
Merged at revision: | 64 |
Proposed branch: | lp:~james-page/charm-helpers/fix_canonical_url |
Merge into: | lp:charm-helpers |
Diff against target: |
57 lines (+6/-4) 2 files modified
charmhelpers/contrib/hahelpers/cluster.py (+2/-1) tests/contrib/hahelpers/test_cluster_utils.py (+4/-3) |
To merge this branch: | bzr merge lp:~james-page/charm-helpers/fix_canonical_url |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charm Helper Maintainers | Pending | ||
Review via email: mp+176359@code.launchpad.net |
Description of the change
Fixup canonical_url to use unit private-address when generating canonical urls for unclustered services.
The local unit hostname is not always resolvable - private-address should be!
To post a comment you must log in.