Charm Helpers

Merge lp:~james-page/charm-helpers/drop-ensure-packages into lp:charm-helpers

  1. drop-ensure-packages
  2. Merge into devel
Proposed by James Page
Status: Merged
Merged at revision: 404
Proposed branch: lp:~james-page/charm-helpers/drop-ensure-packages
Merge into: lp:charm-helpers
Diff against target: 11 lines (+0/-2)
1 file modified
charmhelpers/contrib/openstack/context.py (+0/-2)
To merge this branch: bzr merge lp:~james-page/charm-helpers/drop-ensure-packages
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+264802@code.launchpad.net

Description of the change

Drop call to _ensure_packages

This is used in nova-compute, but we want to make that step configurable for transitioning charms to new subordinate model for SDN's.

To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/contrib/openstack/context.py'
2--- charmhelpers/contrib/openstack/context.py 2015-06-30 15:28:49 +0000
3+++ charmhelpers/contrib/openstack/context.py 2015-07-15 08:26:24 +0000
4@@ -894,8 +894,6 @@
5 return ctxt
6
7 def __call__(self):
8- self._ensure_packages()
9-
10 if self.network_manager not in ['quantum', 'neutron']:
11 return {}
12

Subscribers

People subscribed via source and target branches