lp:~james-page/charm-helpers/configure_source_redux

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:charm-helpers at revision 36

Liam Young (community): Approve on 2013-06-26

Diff: 168 lines (+126/-9)

2 files modified

charmhelpers/fetch/__init__.py (+21/-9)
tests/fetch/test_fetch.py (+105/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

40. By James Page on 2013-06-26

Tidy lint

39. By James Page on 2013-06-26

Fixup failing test for cloud: type

38. By James Page on 2013-06-25

Rebase against trunk

37. By James Page on 2013-06-24

Really fixup cloud archive stuff

36. By James Page on 2013-06-24

Fixup cloud: handling

35. By James Page on 2013-06-24

Rebase against trunk

34. By James Page on 2013-06-24

Fixup configure_source/add_source functions; add tests.

33. By James Page on 2013-06-23

[stub] Misc fixes around use of Serializable including:

1) Make Serializable pickleable

2) Ensure string results are usable strings

32. By Matthew Wedgwood on 2013-06-21

[james-page] Refactoring of service control code in host helper

1) Use 'service' command for all service control

Detecting upstart and init.d configuration files is overkill; this is
exactly what the 'service' command is design todo and it also deals with
saucy onwards where init.d and upstart configuration with the same
name might be installed.

'service' will always do the right thing

2) Added restart and reload helpers

reload detects an error (say the service is not running) and will fallback
to restart if so.

This is inline with the openstack charm helpers code.

31. By Matthew Wedgwood on 2013-06-19

[james-page] Various refactoring + additions to hookenv

1) cached decorator

Allows caching of function + args to avoid repeated calls out the cli
to juju commands.

2) Normalizing missing unit/config/relation data to None

relation_get('missing') == None
config('missing') == None
unit_get('missing') == None

3) Normalized use of the Serializable object a bit

And added a unit test to cover missing attribute lookups

Question: maybe this should actually return 'None' rather than throwing
an exception inline with 2).

4) Tweaks some tests to be closer to juju behaviour with json

5) Tidied misc pep8/pylint warnings.