Merge lp:~james-page/charm-helpers/bug-1413862 into lp:charm-helpers

[James Page]

This change ensures that the call:

if 'shared-db' in CONTEXT.complete_context():
   ...

has the right effecting during the multi-phase setup of database access
for percona-cluster or mysql configured with 'access-network'.

[Liam Young (gnuoy)]

Approve

review: Approve

=== modified file 'charmhelpers/contrib/openstack/context.py'
--- charmhelpers/contrib/openstack/context.py	2015-02-24 12:33:47 +0000
+++ charmhelpers/contrib/openstack/context.py	2015-03-02 10:13:07 +0000
@@ -191,7 +191,7 @@
                                         unit=local_unit())
             if set_hostname != access_hostname:
                 relation_set(relation_settings={hostname_key: access_hostname})
-                return ctxt  # Defer any further hook execution for now....
+                return None  # Defer any further hook execution for now....
 
         password_setting = 'password'
         if self.relation_prefix:

=== modified file 'tests/contrib/openstack/test_os_contexts.py'
--- tests/contrib/openstack/test_os_contexts.py	2015-02-24 12:33:47 +0000
+++ tests/contrib/openstack/test_os_contexts.py	2015-03-02 10:13:07 +0000
@@ -457,7 +457,7 @@
         self.config.side_effect = fake_config(SHARED_DB_CONFIG)
         shared_db = context.SharedDBContext()
         result = shared_db()
-        self.assertEquals(result, {})
+        self.assertEquals(result, None)
         self.relation_set.assert_called_with(
             relation_settings={
                 'hostname': '10.5.5.1'})