Merge lp:~jameinel/maas/tags-exposing-nodes into lp:~maas-committers/maas/trunk
Proposed by
John A Meinel
Status: | Merged |
---|---|
Approved by: | Martin Packman |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1077 |
Proposed branch: | lp:~jameinel/maas/tags-exposing-nodes |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
137 lines (+77/-4) 4 files modified
src/maasserver/api.py (+1/-4) src/maasserver/models/tag.py (+18/-0) src/maasserver/tests/test_api.py (+22/-0) src/maasserver/tests/test_tag.py (+36/-0) |
To merge this branch: | bzr merge lp:~jameinel/maas/tags-exposing-nodes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
Review via email: mp+126438@code.launchpad.net |
Commit message
/tag/<tagname>
Respect that if there is a node owner, it doesn't get shown to anyone but superusers and that owner.
Description of the change
See commit message.
To post a comment you must log in.
Looks good, apart from test_get_ nodes_returns_ everything_ for_superuser not setting `user2.is_superuser = True` which you've now fixed already.