Merge lp:~jameinel/maas/merge-1.2 into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | John A Meinel |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1336 |
Proposed branch: | lp:~jameinel/maas/merge-1.2 |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
17 lines (+7/-0) 1 file modified
src/maasserver/api.py (+7/-0) |
To merge this branch: | bzr merge lp:~jameinel/maas/merge-1.2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
Review via email: mp+133418@code.launchpad.net |
Commit message
Merge the lp:maas/1.2 branch into lp:maas and resolve conflicts.
There were a few text conflicts introduced because of the cherrypicks back to 1.2, but this should make it easier to keep 1.2 changes in sync with trunk.
Description of the change
This gets 1.2 synced into trunk, including our recent changes for kernel options. Probably the only thing that concerns me is the db migration number gets reused (0043). I did test upgrading 1.2 => trunk, which succeeds, and None => trunk which also works fine. No tests fail, so I'm pretty comfortable that everything is ok.
If we do decide to revert the 1.2 changes to keep a simple bugfix-only SRU, then we can probably just remove the kernel_opts patch entirely, and regenerate it later.
After this lands, it should be easy to cherry pick something from trunk back into 1.2, and then merge 1.2 up to trunk. You'll want to do that quickly, because once trunk changes the cherrypick again, you'll end up getting a merge conflict if you haven't merged up already. With a merge-up, things will stay flowing smoothly.
Looks fine, you probably just want to poke Nick so he knows you've forward ported this doc update.