Code review comment for lp:~jameinel/maas/1.2-kernel-option-tags

Revision history for this message
John A Meinel (jameinel) wrote :

I'm not sure what you're thinking on the 'second part'. We can make it the empty string if we would rather not have it be None.

As for the "we still want some kernel params", a lot of the commandline we pass to the booting node is generated from state held in the region controller. So we will always be passing something.

If there are a few particular static parameters that we are passing, we could probably move those into a default global setting (especially if we want to be able to clearly override them). If we do that, though, we'll want some sort of 'reset to defaults' setting, in case you royally hose your system.

« Back to merge proposal