+ should be used when booting this node. May be None if no tags match
+ and no global setting has been configured.
I think we should probably ensure the second part of the tuple here is never None. If the global config is not set, we still want some kernel params. Maybe they should live in the maasserver code, or just be the empty string?
+ tags = tags.order_by('name')[:1]
+ tag = get_one(tags)
+ if tag is not None:
Looks good.
+ should be used when booting this node. May be None if no tags match
+ and no global setting has been configured.
I think we should probably ensure the second part of the tuple here is never None. If the global config is not set, we still want some kernel params. Maybe they should live in the maasserver code, or just be the empty string?
+ tags = tags.order_ by('name' )[:1]
+ tag = get_one(tags)
+ if tag is not None:
I trust this is sensible ORM magic.