Merge lp:~jameinel/launchpadlib/py27-config-ordering-1020667 into lp:launchpadlib
Proposed by
John A Meinel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Martin Packman | ||||
Approved revision: | 131 | ||||
Merged at revision: | 131 | ||||
Proposed branch: | lp:~jameinel/launchpadlib/py27-config-ordering-1020667 | ||||
Merge into: | lp:launchpadlib | ||||
Diff against target: |
23 lines (+5/-5) 1 file modified
src/launchpadlib/docs/introduction.txt (+5/-5) |
||||
To merge this branch: | bzr merge lp:~jameinel/launchpadlib/py27-config-ordering-1020667 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
Review via email: mp+113382@code.launchpad.net |
Commit message
Don't rely on ConfigParser's ordering of content.
Description of the change
It appears that launchpadlib itself doesn't run most of the doctests. So we only run them when running the Launchpad test suite.
It turns out that python-2.7 changed the ordering of config file entries for ConfigParser.
The new ordering is actually stable (OrderedDict), but to be compatible with 2.6 and 2.7, I just switched to adding a sorted() call around it.
To post a comment you must log in.
Note, if this is approved, we'll want a new release of launchpadlib, so that we can update the Launchpad dependencies, so that we can get a clean test suite run of Launchpad for python-2.7.