Merge lp:~jameinel/launchpad/py27-parse-response-1018768 into lp:launchpad
Proposed by
John A Meinel
Status: | Merged |
---|---|
Approved by: | Jelmer Vernooij |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15515 |
Proposed branch: | lp:~jameinel/launchpad/py27-parse-response-1018768 |
Merge into: | lp:launchpad |
Diff against target: |
15 lines (+7/-1) 1 file modified
lib/lp/bugs/externalbugtracker/xmlrpc.py (+7/-1) |
To merge this branch: | bzr merge lp:~jameinel/launchpad/py27-parse-response-1018768 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | Approve | ||
Review via email: mp+112537@code.launchpad.net |
Commit message
Add compatibility for python2.7's xmlrpclib.
Description of the change
This adds a compatibility check for a change to xmlrpclib.Transport in python 2.7 vs 2.6.
They changed the '_parse_response' function, making it public, and removing the 'sock' attribute (for which we were passing None anyway).
This adds 6 lines of code, however when an official switch to python-2.7 is made, all of those extra lines can just be removed.
To post a comment you must log in.
Thanks.