Launchpad itself

Merge lp:~jameinel/launchpad/lp-serve-cleanup into lp:launchpad

  1. lp-serve-cleanup
  2. Merge into devel
Proposed by John A Meinel on 2010-07-21
Status: Merged
Approved by: Jonathan Lange on 2010-07-21
Approved revision: no longer in the source branch.
Merged at revision: 11262
Proposed branch: lp:~jameinel/launchpad/lp-serve-cleanup
Merge into: lp:launchpad
Diff against target: 32 lines (+4/-4)
1 file modified
lib/lp/services/sshserver/tests/test_session.py (+4/-4)
To merge this branch: bzr merge lp:~jameinel/launchpad/lp-serve-cleanup
Reviewer Review Type Date Requested Status
Jonathan Lange (community) Approve on 2010-07-21
Review via email: mp+30542@code.launchpad.net

Commit Message

Comment cleanup from "ExecOnlySession" to "DoNothingSession"

Description of the Change

This is a rather minor cleanup, just of comments, etc. The tests in question were copied from elsewhere but are testing the DoNothingSession but claimed to be testing the ExecOnlySession.

To post a comment you must log in.
Jonathan Lange (jml) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/services/sshserver/tests/test_session.py'
2--- lib/lp/services/sshserver/tests/test_session.py 2010-06-25 17:19:11 +0000
3+++ lib/lp/services/sshserver/tests/test_session.py 2010-07-21 14:41:26 +0000
4@@ -48,7 +48,7 @@
5
6
7 class TestDoNothing(TestCase):
8- """Tests for ExecOnlySession."""
9+ """Tests for DoNothingSession."""
10
11 def setUp(self):
12 super(TestDoNothing, self).setUp()
13@@ -77,16 +77,16 @@
14 self.session.windowChanged, None)
15
16 def test_providesISession(self):
17- # ExecOnlySession must provide ISession.
18+ # DoNothingSession must provide ISession.
19 self.failUnless(ISession.providedBy(self.session),
20- "ExecOnlySession doesn't implement ISession")
21+ "DoNothingSession doesn't implement ISession")
22
23 def test_closedDoesNothing(self):
24 # closed is a no-op.
25 self.assertEqual(None, self.session.closed())
26
27 def test_execCommandNotImplemented(self):
28- # ExecOnlySession.execCommand spawns the appropriate process.
29+ # DoNothingSession.execCommand spawns the appropriate process.
30 protocol = MockProcessTransport('bash')
31 command = 'cat /etc/hostname'
32 self.session.execCommand(protocol, command)