Code review comment for lp:~jameinel/launchpad/lp-serve-child-hangup

Revision history for this message
Martin Pool (mbp) wrote :

> It turns out it is exposed, but only conditionally, and not where I
> expected it.
>
> import signal
> signal.alarm()
>
> If you prefer, I'd be happy to use that instead. Should I be catching
> SIGALRM, or should I just let it propagate to kill the child?

Since it's supposed to be an unusual case that the connection fails
half way through, I think just letting it kill the client should be
fine. The parent should wait on them and log their exit status.

« Back to merge proposal