Code review comment for lp:~jameinel/launchpad/lp-serve-child-hangup

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...

>
> If you do need a signal to interrupt things, how about just using alarm(2)?
>

It turns out it is exposed, but only conditionally, and not where I
expected it.

import signal
signal.alarm()

If you prefer, I'd be happy to use that instead. Should I be catching
SIGALRM, or should I just let it propagate to kill the child?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1j/c0ACgkQJdeBCYSNAANc0QCeLE9a+01g55AbrIa5EVWGmNdh
tukAn3Ybnl0SCYTqoxNKIu0VHvz95+r7
=LF2C
-----END PGP SIGNATURE-----

« Back to merge proposal