Code review comment for lp:~jameinel/launchpad/lp-serve-child-hangup

Revision history for this message
Martin Pool (mbp) wrote :

On 17 February 2011 10:01, Robert Collins <email address hidden> wrote:
> On Thu, Feb 17, 2011 at 11:38 AM, John A Meinel <email address hidden> wrote:
>> I would expect something similar from dup2.
> I would expect dup2 to workaround those bugs :) - its why I suggested it.

We want to do a nonblocking open, so we don't have an fd to dup until
we've done that.

After opening it, maybe we could dup it, then make the new copy
blocking, then close the original. It's possible that would work
around it. On the other hand if in general we can't make open fds
blocking, it may not fix it.

« Back to merge proposal