Code review comment for lp:~jameinel/launchpad/lp-serve-child-hangup

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...

>> I don't really like spawning a thread to send SIGUSR1 back to myself, but it seemed the best tradeoff. If we want, we could even make it SIGTERM or something, since we know we are going to kill the process if the connection fails.
>
> I don't really like that either, especially this is already getting to
> be a fairly complex set of processes.
>
> Why can't you make the file handles nonblocking and just leave them
> so? Is it because they're later inherited by some other process?

Because the Smart server code expects blocking file handles.
SmartServerPipeStreamMedium IIRC.

>
> If you do need a signal to interrupt things, how about just using alarm(2)?

Because alarm doesn't seem to be exposed to python, and I want the
ability to cancel the callback. threading.Timer() gives me that exact
functionality.

I would be fine using SIGALRM if you prefer that to SIGUSR1.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1cS8UACgkQJdeBCYSNAAMupgCgjFH3eTQXY6vxSoZkp3inrYs7
CjQAnREQQ/NXmuuyz9Rkl8tUMNIFEED6
=iiu5
-----END PGP SIGNATURE-----

« Back to merge proposal