Merge lp:~jameinel/launchpad/loggerhead-test-suite-742446 into lp:launchpad
| Status: | Merged |
|---|---|
| Approved by: | Abel Deuring |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12674 |
| Proposed branch: | lp:~jameinel/launchpad/loggerhead-test-suite-742446 |
| Merge into: | lp:launchpad |
| Diff against target: |
29 lines (+9/-2) 2 files modified
lib/launchpad_loggerhead/tests.py (+8/-1) utilities/sourcedeps.conf (+1/-1) |
| To merge this branch: | bzr merge lp:~jameinel/launchpad/loggerhead-test-suite-742446 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Abel Deuring (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Include the loggerhead test suite as part of the Launchpad test suite.
Description of the change
This updates the Launchpad test suite to incorporate the Loggerhead test suite.
Now that the loggerhead test suite runs cleanly, it makes sense to run it as part of regular testing. I did check, and it would have caught:
https:/
This way, we can be sure that loggerhead's test suite is being run in the same configuration that is being deployed.
The reason this change includes a bump to the revision of loggerhead, is because there was 1 fix needed in Loggerhead itself. (loggerhead runs both as a plugin of bzr and as a standalone app. Launchpad runs it as a standalone app, so it is not accessible as 'bzrlib.
This also includes Jelmer's bugfix to properly support foreign revisions (revno 434). I don't believe this is an issue in production, since I don't think we run loggerhead with bzr-svn available. (And if we did, then we should have been getting OOPses in production that his patch will fix.)
The update does expose: https:/
Which is that loggerhead's tests seem to be leaking threads. However, that doesn't seem to cause Launchpad's test runner to fail, and I don't know what that means for Launchpad's test suite.
| Abel Deuring (adeuring) | # |
