lp:~jameinel/juju-core/reflect-registry

Created by John A Meinel on 2014-05-10 and last modified on 2014-05-12
Get this branch:
bzr branch lp:~jameinel/juju-core/reflect-registry
Only John A Meinel can upload to this branch. If you are John A Meinel please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
John A Meinel
Project:
juju-core
Status:
Development

Recent revisions

2733. By John A Meinel on 2014-05-12

Merge reflect-only-facades to get the fixes for running the test suite.

2732. By John A Meinel on 2014-05-12

Merge typed-registry, and fix up go fmt.

2731. By John A Meinel on 2014-05-11

merge the updated TypedNameVersion registry and use it in the RPC code.

2730. By John A Meinel on 2014-05-11

merge typed registry, which brings in a newer trunk

2729. By John A Meinel on 2014-05-11

Merge test removal, in preparation for next level

2728. By John A Meinel on 2014-05-11

we don't actually need to change KillerRoot

2727. By John A Meinel on 2014-05-11

Unwrapping more layers starts to look good.

I'm slowly unteasing what we actually want for rpc.Serve.
Rather than wanting an object and using rpcreflect.Value, what we really
just want is something that implements MethodCaller and possibly Kill.
This should make it easily possible for an external implementation to
provide a custom way of mapping requests (alternative Registry, etc.)

2726. By John A Meinel on 2014-05-11

Move the code into its own dir, since it isn't really related to rpcreflect anymore.
We use a couple of the functions, and some of MethodCaller is private that we want to
set, so we exposed it as a public function instead of a private one.
Arguably CallNotImplementedError should be in 'common' and shared into
both of them.
MethodCaller as a type could be just shared, but MethodCallerFromValue uses ObjTypeOf, and
thus does depend on 'rpcreflect'. (so rpcreflect couldn't import it from somewhere else, as
it has to call back into rpcreflect.)

2725. By John A Meinel on 2014-05-11

lots of doc strings

2724. By John A Meinel on 2014-05-11

Switch to returning all known versions.

The returned slice is sorted, so if we wanted just Min and Max, you can always
use [0] and [len(slice)-1] to get the min and max.
It also is easy with a sorted slice to check if there are any gaps.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:~go-bot/juju-core/trunk
This branch contains Public information 
Everyone can see this information.

Subscribers