Merge lp:~jameinel/gwacl/failing-subdir-test into lp:~go-bot/gwacl/test

Proposed by John A Meinel on 2013-08-29
Status: Needs review
Proposed branch: lp:~jameinel/gwacl/failing-subdir-test
Merge into: lp:~go-bot/gwacl/test
Diff against target: 11 lines (+4/-0)
1 file modified
dedent/dedent_test.go (+4/-0)
To merge this branch: bzr merge lp:~jameinel/gwacl/failing-subdir-test
Reviewer Review Type Date Requested Status
John A Meinel Approve on 2013-08-29
Review via email: mp+182824@code.launchpad.net

Commit message

Please reject this. If it gets merged, then I will be sad.

Description of the change

This should fail because there is a test case that fails in a subdirectory.

To post a comment you must log in.
John A Meinel (jameinel) :
review: Approve
Go Bot (go-bot) wrote :

The attempt to merge lp:~jameinel/gwacl/failing-subdir-test into lp:~go-bot/gwacl/test failed. Below is the output from the failed tests.

deletedisk.go
deletedisk_test.go
endpoints.go
endpoints_test.go
helpers_apiobjects_test.go
helpers_factory_test.go
helpers_http_test.go
helpers_misc_test.go
httperror.go
httperror_test.go
management.go
management_base.go
management_base_test.go
management_test.go
master_test.go
names.go
names_test.go
poller.go
poller_test.go
random.go
retry_policy.go
retry_policy_test.go
rolesizes.go
rolesizes_test.go
shared_signature.go
shared_signature_test.go
storage.go
storage_base.go
storage_base_test.go
storage_test.go
testhelpers_x509dispatch.go
testing.go
testing_test.go
utils.go
utils_test.go
vhd_footer_test.go
x509dispatcher.go
x509dispatcher_test.go
x509session.go
x509session_test.go
xmlobjects.go
xmlobjects_test.go
dedent/dedent.go
dedent/dedent_test.go
example/management/run.go
example/storage/run.go
fork/http/chunked.go
fork/http/client.go
fork/http/cookie.go
fork/http/filetransport.go
fork/http/fs.go
fork/http/header.go
fork/http/jar.go
fork/http/lex.go
fork/http/request.go
fork/http/response.go
fork/http/server.go
fork/http/sniff.go
fork/http/status.go
fork/http/transfer.go
fork/http/transport.go
fork/http/triv.go
fork/tls/alert.go
fork/tls/cipher_suites.go
fork/tls/common.go
fork/tls/conn.go
fork/tls/generate_cert.go
fork/tls/handshake_client.go
fork/tls/handshake_messages.go
fork/tls/handshake_server.go
fork/tls/key_agreement.go
fork/tls/prf.go
fork/tls/tls.go
logging/logging.go
logging/logging_test.go
? launchpad.net/gwacl/example/management [no test files]
? launchpad.net/gwacl/example/storage [no test files]
? launchpad.net/gwacl/fork/http [no test files]
? launchpad.net/gwacl/fork/tls [no test files]

# launchpad.net/gwacl
deletedisk_test.go:8:2: cannot find package "launchpad.net/gocheck" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gocheck (from $GOROOT)
 /home/tarmac/gwacl-trees/src/launchpad.net/gocheck (from $GOPATH)
# launchpad.net/gwacl/dedent
deletedisk_test.go:8:2: cannot find package "launchpad.net/gocheck" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gocheck (from $GOROOT)
 /home/tarmac/gwacl-trees/src/launchpad.net/gocheck (from $GOPATH)
# launchpad.net/gwacl/logging
deletedisk_test.go:8:2: cannot find package "launchpad.net/gocheck" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gocheck (from $GOROOT)
 /home/tarmac/gwacl-trees/src/launchpad.net/gocheck (from $GOPATH)

Go Bot (go-bot) wrote :

The attempt to merge lp:~jameinel/gwacl/failing-subdir-test into lp:~go-bot/gwacl/test failed. Below is the output from the failed tests.

./utilities/format -s
ok launchpad.net/gwacl 0.331s

----------------------------------------------------------------------
FAIL: dedent_test.go:96: dedentSuite.TestShouldFail

dedent_test.go:97:
    c.Fatal("This should fail in a subdirectory")
... Error: This should fail in a subdirectory

OOPS: 9 passed, 1 FAILED
--- FAIL: Test (0.00 seconds)
FAIL
FAIL launchpad.net/gwacl/dedent 0.015s
? launchpad.net/gwacl/example/management [no test files]
? launchpad.net/gwacl/example/storage [no test files]
? launchpad.net/gwacl/fork/http [no test files]
? launchpad.net/gwacl/fork/tls [no test files]
ok launchpad.net/gwacl/logging 0.010s

warning: building out-of-date packages:
 launchpad.net/gocheck
installing these packages with 'go test -i ./...' will speed future tests.

Unmerged revisions

222. By John A Meinel on 2013-08-29

Fail tests in a subdir

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dedent/dedent_test.go'
2--- dedent/dedent_test.go 2013-03-26 06:57:55 +0000
3+++ dedent/dedent_test.go 2013-08-29 05:42:15 +0000
4@@ -92,3 +92,7 @@
5 func Test(t *testing.T) {
6 TestingT(t)
7 }
8+
9+func (suite *dedentSuite) TestShouldFail(c *C) {
10+ c.Fatal("This should fail in a subdirectory")
11+}

Subscribers

People subscribed via source and target branches

to all changes: