Merge lp:~jameinel/gwacl/build-failure into lp:~go-bot/gwacl/test

Proposed by John A Meinel on 2013-08-29
Status: Needs review
Proposed branch: lp:~jameinel/gwacl/build-failure
Merge into: lp:~go-bot/gwacl/test
Diff against target: 25 lines (+4/-0)
2 files modified
utils.go (+2/-0)
utils_test.go (+2/-0)
To merge this branch: bzr merge lp:~jameinel/gwacl/build-failure
Reviewer Review Type Date Requested Status
John A Meinel Approve on 2013-08-29
Review via email: mp+182826@code.launchpad.net

Commit message

Please bot, notice that my build is poor, and do not land this.

Description of the change

This should fail.
While it should pass the test suite, there is a bad dependency (something is defined in a _test file and referenced in a non _test file).

So go build fails, but not go test.

To post a comment you must log in.
John A Meinel (jameinel) :
review: Approve
Go Bot (go-bot) wrote :

The attempt to merge lp:~jameinel/gwacl/build-failure into lp:~go-bot/gwacl/test failed. Below is the output from the failed tests.

deletedisk.go
deletedisk_test.go
endpoints.go
endpoints_test.go
helpers_apiobjects_test.go
helpers_factory_test.go
helpers_http_test.go
helpers_misc_test.go
httperror.go
httperror_test.go
management.go
management_base.go
management_base_test.go
management_test.go
master_test.go
names.go
names_test.go
poller.go
poller_test.go
random.go
retry_policy.go
retry_policy_test.go
rolesizes.go
rolesizes_test.go
shared_signature.go
shared_signature_test.go
storage.go
storage_base.go
storage_base_test.go
storage_test.go
testhelpers_x509dispatch.go
testing.go
testing_test.go
utils.go
utils_test.go
vhd_footer_test.go
x509dispatcher.go
x509dispatcher_test.go
x509session.go
x509session_test.go
xmlobjects.go
xmlobjects_test.go
dedent/dedent.go
dedent/dedent_test.go
example/management/run.go
example/storage/run.go
fork/http/chunked.go
fork/http/client.go
fork/http/cookie.go
fork/http/filetransport.go
fork/http/fs.go
fork/http/header.go
fork/http/jar.go
fork/http/lex.go
fork/http/request.go
fork/http/response.go
fork/http/server.go
fork/http/sniff.go
fork/http/status.go
fork/http/transfer.go
fork/http/transport.go
fork/http/triv.go
fork/tls/alert.go
fork/tls/cipher_suites.go
fork/tls/common.go
fork/tls/conn.go
fork/tls/generate_cert.go
fork/tls/handshake_client.go
fork/tls/handshake_messages.go
fork/tls/handshake_server.go
fork/tls/key_agreement.go
fork/tls/prf.go
fork/tls/tls.go
logging/logging.go
logging/logging_test.go

# launchpad.net/gwacl
./utils.go:57: undefined: declaredInTestModule
./utils.go:57: cannot assign to declaredInTestModule

Go Bot (go-bot) wrote :

The attempt to merge lp:~jameinel/gwacl/build-failure into lp:~go-bot/gwacl/test failed. Below is the output from the failed tests.

./utilities/format -s

# launchpad.net/gwacl
./utils.go:57: undefined: declaredInTestModule
./utils.go:57: cannot assign to declaredInTestModule

Unmerged revisions

222. By John A Meinel on 2013-08-29

This generates a build failure but *not* a test failure

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utils.go'
2--- utils.go 2013-07-30 06:49:29 +0000
3+++ utils.go 2013-08-29 05:43:46 +0000
4@@ -54,6 +54,8 @@
5 query.Add(key, value)
6 }
7
8+ declaredInTestModule = 4
9+
10 parsedURL.RawQuery = query.Encode()
11 return parsedURL.String()
12 }
13
14=== modified file 'utils_test.go'
15--- utils_test.go 2013-07-30 06:49:29 +0000
16+++ utils_test.go 2013-08-29 05:43:46 +0000
17@@ -15,6 +15,8 @@
18
19 var _ = Suite(&UtilsSuite{})
20
21+var declaredInTestModule = 5
22+
23 func (suite *UtilsSuite) TestCheckPathComponents(c *C) {
24 checkPathComponents("fred", "bob", "123", "a..b") // All okay.
25 c.Check(

Subscribers

People subscribed via source and target branches

to all changes: