I like the changes. It seems that, at least for trunk, we might consider moving the trace.mutter from bzrlib/osutils.py:66
66 + trace.mutter("ignoring error calling fdatasync: %s" % (e,)) 67 + if getattr(e, 'errno', None) not in _fdatasync_ignored: 68 + raise
into an 'else' of the test on line 67, since only in that case are we actually ignoring the error. Something like the following:
66 + if getattr(e, 'errno', None) not in _fdatasync_ignored: 67 + raise 68 + else: 69 + trace.mutter("ignoring error calling fdatasync: %s" % (e,))
« Back to merge proposal
I like the changes. It seems that, at least for trunk, we might consider moving the trace.mutter from osutils. py:66
bzrlib/
66 + trace.mutter( "ignoring error calling fdatasync: %s" % (e,))
67 + if getattr(e, 'errno', None) not in _fdatasync_ignored:
68 + raise
into an 'else' of the test on line 67, since only in that case are we actually ignoring the error. Something like the following:
66 + if getattr(e, 'errno', None) not in _fdatasync_ignored: "ignoring error calling fdatasync: %s" % (e,))
67 + raise
68 + else:
69 + trace.mutter(