Code review comment for lp:~jameinel/bzr/2.4-overridAttr-non-existant

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> Also, reading the code in monkey.py it *doesn't* handle the
>> delattr case. At least in 0.9.14.final.0 that I have here.
>
> It is there in 0.9.12 and... still there on tip, check again (hint:
> restore()).
>

It will delete an attribute that did not previously exist. There is
*no way* to specify that you want to delete an attribute that already
exists. (Hint *patch*)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Cygwin)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlCZV1oACgkQJdeBCYSNAANGQACfQP4RdjnkBz6nYnochK/lvd9J
x1UAnA7E/yJinS5cxkveUYCOqBqSwn/g
=nb5c
-----END PGP SIGNATURE-----

« Back to merge proposal