Merge lp:~jameinel/bzr/2.4-overridAttr-non-existant into lp:bzr/2.4
Proposed by
John A Meinel
Status: | Merged |
---|---|
Approved by: | John A Meinel |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6073 |
Proposed branch: | lp:~jameinel/bzr/2.4-overridAttr-non-existant |
Merge into: | lp:bzr/2.4 |
Diff against target: |
92 lines (+48/-6) 2 files modified
bzrlib/tests/__init__.py (+8/-2) bzrlib/tests/test_selftest.py (+40/-4) |
To merge this branch: | bzr merge lp:~jameinel/bzr/2.4-overridAttr-non-existant |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
Review via email: mp+132871@code.launchpad.net |
Commit message
Teach TestCase.
Description of the change
This is a precursor branch for another fix I want to land.
Essentially, TestCase.
I'm just submitting it now because it should be clearer factored out into 2 patches.
To post a comment you must log in.
Looks fine, but I'm not sure having special logic for the case where new is uninited and value is uninited makes sense. That doesn't seem like something a test author would do deliberately, except perhaps if they were later in the test setting the attribute to something and wanted the cleanup at the end, in which case the value would leak through in this case.